Merge pull request #1020 from OpenCover/rc

push release

.github/FUNDING.yml

@@ -0,0 +1 @@
+github: sawilde

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,63 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+Please provide the following information when submitting an issue. 
+> Where appropriate replace the `[]` with a `[X]`
+
+**NOTE** Support requests should initially be raised on [GitHub discussions](https://github.com/OpenCover/opencover/discussions) 
+
+### My Framework
+
+- [ ] .NET 2
+- [ ] .NET 3.5
+- [ ] .NET 4
+- [ ] .NET 4.5
+- [ ] .NET 4.6
+- [ ] .NET 4.6.1
+- [ ] .NET 4.6.2
+- [ ] .NET 4.7
+- [ ] .NET 4.7.1
+- [ ] .NET 4.7.2
+- [ ] .NET 4.8
+- [ ] .NET Core 2.2.0
+- [ ] .NET Core 3.1.0
+- [ ] .NET 5
+- only release and LTS versions of .NET runtimes and SDKs will be supported 
+
+### My Environment
+
+- [ ] Windows 7 or below (not truly supported due to EOL)
+- [ ] Windows 8
+- [ ] Windows 8.1
+- [ ] Windows 10
+- [ ] Windows 10 IoT Core
+- [ ] Windows Server 2012
+- [ ] Windows Server 2012 R2
+- [ ] Windows Server 2016
+- [ ] Windows Server 2019
+
+### I have already...
+
+- [ ] repeated the problem using the latest stable release of OpenCover.
+- [ ] reviewed the [usage guide](https://github.com/opencover/opencover/wiki/usage) and [usage document](https://github.com/opencover/opencover/blob/master/main/OpenCover.Documentation/Usage.pdf).
+- [ ] have looked at the opencover output xml file in an attempt to resolve the issue.
+- [ ] reviewed the [current issues](https://github.com/opencover/opencover/issues) to check that the issue isn't already known.
+
+### My issue is related to (check only those which apply):
+
+- [ ] no coverage being recorded
+- [ ] 32 or 64 bit support
+
+### Describe the bug
+A clear and concise description of what the bug is.
+
+### Steps to reproduce the problem:
+
+- [ ] reviewed the [usage guide](https://github.com/opencover/opencover/wiki/usage) and [usage document](https://github.com/opencover/opencover/blob/master/main/OpenCover.Documentation/Usage.pdf) again because we know you probably didn't do it the first time.
+- [ ] sample code or link to repository/gist is available (support is much, much faster this way) 

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: true

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/SUPPORT.md

@@ -0,0 +1,22 @@
+## Support for OpenCover
+
+Welcome to OpenCover! We use GitHub for tracking bugs and feature requests.
+- with also looking at using GitHub discussions for support issues.
+
+### Stack Overflow
+
+The OpenCover Community is active on Stack Overflow, you can post your questions there:
+
+* [OpenCover on Stack Overflow](https://stackoverflow.com/questions/tagged/opencover)
+
+  * Here are some tips for [about how to ask good questions](https://stackoverflow.com/help/how-to-ask).
+  * Don't forget to check to see [what's on topic](http://stackoverflow.com/help/on-topic).
+
+* [OpenCover on GitHub)(https://github.com/OpenCover/opencover/discussions)
+
+  * Before raising a [support issue](https://github.com/OpenCover/opencover/issues) please start a discussion first if it becomes a defect/feature request then an appropriate ticket can be created. 
+
+### Documentation
+
+* [Wiki](https://github.com/OpenCover/opencover/wiki/Usage) or [PDF](https://github.com/OpenCover/opencover/blob/master/main/OpenCover.Documentation/Usage.pdf)
+

.github/contributing.md

@@ -6,7 +6,7 @@ OpenCover is open to all and we encourage the community to contribute in the pro
 
 OpenCover isn't perfect and it will have issues we do our best to stay on top of them but we occasionaly take a break from development to do other things. 
 
-If you are raising an issue please check that you are using the latest version from either our [releases](https://github.com/OpenCover/opencover/releases) or [nuget](https://www.nuget.org/packages/OpenCover/). If the issue persists then please try to supply as much detail as you can and ifpossible supply a sample that we can use to repeat the issue described.  
+If you are raising an issue please check that you are using the latest version from either our [releases](https://github.com/OpenCover/opencover/releases) or [nuget](https://www.nuget.org/packages/OpenCover/). If the issue persists then please try to supply as much detail as you can and if possible supply a sample that we can use to repeat the issue described.  
 
 If you are requesting a feature, please supply why it is useful and what the benefits are. OpenCover was developed to meet a need to have a code coverage tool and so if we haven't yet implemented something we need to be sold on the idea.
 

.github/issue_template.md

@@ -1,56 +1 @@
-Please provide the following information when submitting an issue. 
-
-> Where appropriate replace the `[ ]` with a `[X]`
-
-### My Framework
-
-- [ ] .NET 2
-- [ ] .NET 3.5
-- [ ] .NET 4
-- [ ] .NET 4.5
-- [ ] .NET 4.6
-- [ ] .NET 4.6.1
-- [ ] .NET 4.6.2
-- [ ] .NET 4.7
-- [ ] .NET 4.7.1
-- [ ] .NET 4.7.2
-- [ ] .NET Core 1.0.0
-- [ ] .NET Core 2.0.0
-- [ ] Something else
-
-### My Environment
-
-- [ ] Windows 7 or below (not truly supported due to EOL)
-- [ ] Windows 8
-- [ ] Windows 8.1
-- [ ] Windows 10
-- [ ] Windows 10 IoT Core
-- [ ] Windows Server 2012
-- [ ] Windows Server 2012 R2
-- [ ] Windows Server 2016
-
-### I have already...
-
-- [ ] repeated the problem using the latest stable release of OpenCover.
-- [ ] reviewed the [usage guide](https://github.com/opencover/opencover/wiki/usage) and [usage document](https://github.com/opencover/opencover/blob/master/main/OpenCover.Documentation/Usage.pdf).
-- [ ] have looked at the opencover output xml file in an attempt to resolve the issue.
-- [ ] reviewed the [current issues](https://github.com/opencover/opencover/issues) to check that the issue isn't already known.
-
-### My issue is related to (check only those which apply):
-
-- [ ] no coverage being recorded
-- [ ] 32 or 64 bit support
-- [ ] feature request
-
-### Expected Behavior
-
-Fill me in...
-
-### Actual Behavior
-
-Fill me in...
-
-### Steps to reproduce the problem:
-
-- [ ] reviewed the [usage guide](https://github.com/opencover/opencover/wiki/usage) and [usage document](https://github.com/opencover/opencover/blob/master/main/OpenCover.Documentation/Usage.pdf) again because we know you probably didn't do it the first time.
-- [ ] sample code or link to repository/gist is available (support is much faster this way) 
+**Support requests** should initially be raised on [GitHub discussions](https://github.com/OpenCover/opencover/discussions) 

.gitignore

@@ -92,8 +92,7 @@ coverity.zip
 #chocolatey
 /main/bin/chocpackage/*.nupkg
 /samples/SampleSln.zip
-/main/OpenCover.Packages/chocolatey/opencover/tools/chocolateyInstall.ps1
-/main/OpenCover.Packages/chocolatey/opencover.portable/tools/chocolateyInstall.ps1
+/main/OpenCover.Packages/chocolatey/**/chocolateyInstall.ps1
 
 #OpenCppCoverage
 /CoverageReport*/**/*

README.md

@@ -1,25 +1,23 @@
-OpenCover is a code coverage tool for .NET 2 and above (Windows OSs only - no MONO), with support for 32 and 64 processes and covers both branch and sequence points. OpenCover was started after attempts to make PartCover support 64-bit processes got just a [little too complicated](http://blog.many-monkeys.com/open_cover_first_beta_release/).
+OpenCover is a code coverage tool for .NET 2 and above (Windows OSs only - no MONO)<sup>*</sup>, with support for 32 and 64 processes and covers both branch and sequence points. OpenCover was started after attempts to make PartCover support 64-bit processes got just a [little too complicated](http://blog.many-monkeys.com/open_cover_first_beta_release/).
+
+* OpenCover should have few issues with any application compiled against any of the .NET Full Frameworks. Applications targetting .Net Core may encounter issues but using the `-oldstyle` switch usually works.
 
 The latest releases can be downloaded from [releases](https://github.com/opencover/opencover/releases). **Alternatively** why not try the [nuget](http://nuget.org/packages/opencover) package (this is the most popular).
 
 | | Active Integrations |
 | --- | --- |
 | **Build** | [![Build status](https://img.shields.io/appveyor/ci/sawilde/opencover.svg)](https://ci.appveyor.com/project/sawilde/opencover) |
 | **Coverage** | <sup>Coveralls</sup> [![Coveralls](https://img.shields.io/coveralls/OpenCover/opencover/master.svg)](https://coveralls.io/r/OpenCover/opencover) |
+| **Quality** | [![Coverity](https://scan.coverity.com/projects/3921/badge.svg)](https://scan.coverity.com/projects/opencover-opencover) |
 | **Nuget** | [![Nuget](https://buildstats.info/nuget/opencover)](http://nuget.org/packages/opencover)  [![Nuget](https://img.shields.io/nuget/vpre/opencover.svg)](http://nuget.org/packages/opencover) |
 | **Agreements** | [![CLA assistant](https://cla-assistant.io/readme/badge/OpenCover/opencover)](https://cla-assistant.io/OpenCover/opencover) |
 
-| | Disabled Integrations |
-| --- | --- |
-| **Coverage** | <sup>SonarCloud</sup> [![SonarCloud](https://sonarcloud.io/api/project_badges/measure?project=opencover&metric=coverage)](https://sonarcloud.io/dashboard?id=opencover) |
-| **Quality** | [![SonarCloud](https://sonarcloud.io/api/project_badges/measure?project=opencover&metric=alert_status)](https://sonarcloud.io/dashboard?id=opencover) |
-| **Quality** | [![Coverity](https://scan.coverity.com/projects/3921/badge.svg)](https://scan.coverity.com/projects/opencover-opencover) |
-
 ### Master
 The primary repo for the project is [on GitHub](https://github.com/opencover/opencover/) and is also where the [wiki](https://github.com/OpenCover/opencover/wiki) and [issues](https://github.com/OpenCover/opencover/wiki) are managed from.
 
-### Team slack (*new* Jan 2019)
-[![Slack](https://img.shields.io/badge/chat-%20slack%20-brightgreen.svg)](https://join.slack.com/t/opencover/shared_invite/enQtNTI4NDA5MDA4MDUzLTE1MTllZjdiYmVjZmZiMGVjNWNjZGM1OWNiY2QwODY1NDA5OGNiYTVkYWQxN2IwNzc5NTE0MGJiOTI5MzkzZDE)
+### Requirements
+
+1) .NET 4.7.2 is needed to run opencover
 
 ### Submissions and Community Licence Agreement
 You will be asked to agree to a CLA as part of the submission process; first pull request only and it's all automatic no printing and signing etc. You can read the agreement here - [OpenCover CLA](https://gist.github.com/sawilde/4820db0a6151a1144a0c) and you can read our [Q&A](https://github.com/OpenCover/opencover/wiki/Contributor-License-Agreement-Q&A) on the wiki as to why.
@@ -37,8 +35,12 @@ All Original Software is licensed under the [MIT Licence](https://github.com/ope
 
 If anyone is aware of any licence violations that this code may be making please inform the developers so that the issue can be investigated and rectified.
 
+### Visual Studio Integration
+The following add-in for visual studio can be used to run and view coverage results within the IDE
+https://github.com/FortuneN/FineCodeCoverage
+
 ### Integration Test support
-OpenCover was initially created to support unit testing techniques such as TDD and tools like NUnit and MSTest. Over time others have found ways to use OpenCover for integration testing especially in tricky scenarios such as IIS and Windows Services. I'll put links here as to how people have achieved this however as they say YMMV (You Mileage May Vary).
+OpenCover was initially created to support unit testing techniques such as TDD and tools like NUnit and MSTest. Over time others have found ways to use OpenCover for integration testing especially in tricky scenarios such as IIS and Windows Services. I'll put links here as to how people have achieved this however as they say YMMV (Your Mileage May Vary).
 
 #### Mono support
 It isn't, sorry - this tool uses the profiler API that is currently only available to .NET Frameworks running on the Windows platform.
@@ -61,11 +63,16 @@ Please refer to the wiki - [Silverlight support](https://github.com/OpenCover/op
 ### Building
 You will need:
 
-1. Visual Studio VS2017 (Community Edition) or later with C#, C++, .Net Core
-2. WiX 3.11 or later (http://wixtoolset.org/releases/) and Votive 2017 (https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension)
-3. SpecFlow for Visual Studio 2017 (https://marketplace.visualstudio.com/items?itemName=TechTalkSpecFlowTeam.SpecFlowforVisualStudio2017)
-4. Windows SDK 10 and .NET Framework Tools (https://msdn.microsoft.com/en-us/windows/desktop/bg162891.aspx)
-5. Microsoft .NET Framework 4.7.2 Developer Pack (https://dotnet.microsoft.com/download/visual-studio-sdks)
+To build from the command line:
+1. Visual Studio VS2019 (Community Edition) with C#, C++, .Net Core
+2. .NET SDK 2.2.402 (https://dotnet.microsoft.com/download/thank-you/dotnet-sdk-2.1.4-windows-x64-installer)
+- runtimes ???
+3. WiX 3.11 or later (http://wixtoolset.org/releases/) and Votive 2019 (https://marketplace.visualstudio.com/items?itemName=WixToolset.WixToolsetVisualStudio2019Extension)
+4. Windows SDK 10 (10.0.18362.0) and .NET Framework Tools (https://msdn.microsoft.com/en-us/windows/desktop/bg162891.aspx)
+
+To build and run from within visual studio:
+5. SpecFlow for Visual Studio 2017 (https://marketplace.visualstudio.com/items?itemName=TechTalkSpecFlowTeam.SpecFlowForVisualStudio)
+6. Microsoft .NET Framework 4.7.2 Developer Pack (https://dotnet.microsoft.com/download/visual-studio-sdks)
 
 All other software should be included with this repository.
 

ReleaseNotes.tmp

@@ -1,4 +1,19 @@
+Requires .NET Framework 4.7.2
+
 Version [[version]]
+#877 remove incorrect redirects (bug)
+#964 address CVE-2018-1285 in log4net 2.0.8 (prj-mgmt)
+#910 import MSBuild project from NuGet package (feature)
+#953 update Sentry to latest version (prj-mgmt)
+#908 fix race condition causing modules to appear twice in output (bug)
+#930 add .Net framework 4.7.2 detection to installer (prj-mgmt)
+#728 extend max configuable comm timeout to 600s (bug/feature)
+#914, #725 additional messaging around no coverage (prj-mgmt)
+#993 fix issue with FieldReference handling preventing assembly from loading (bug)
+#960 ignore empty branches created by unoptimised code (feature)
+#809 ignore fsharp auto properties
+
+Version 4.7.922
 #855 change crash reporting framework to Sentry (feature/prj-mgmt)
 #735 apply checksums to chocolatey packages (feature/prj-mgmt)
 #825 handle pdb mismatch and continue (fix)

appveyor.yml

@@ -1,6 +1,6 @@
 version: 4.7.{build}
 skip_tags: true
-image: Visual Studio 2017
+image: Visual Studio 2019
 shallow_clone: true
 environment:
   COVERALLS_REPO_TOKEN:
@@ -68,6 +68,8 @@ artifacts:
   name: Chocolatey
 - path: main/bin/packages/chocolatey/opencover.portable/*.nupkg
   name: ChocolateyPortable
+- path: main/bin/packages/chocolatey/opencover.install/*.nupkg
+  name: ChocolateyInstall
 - path: cov-int/build-log.txt
   name: Coverity
 - path: GenericCoverage.xml
@@ -77,11 +79,19 @@ artifacts:
 deploy:
 - provider: NuGet
   api_key:
-    secure: rSx36T78ZXIqD2Tk/DatbUP05MiHgxTWjOIGquhzWeTJX0VEB4Mn2TZyi0zMtGIL
+    secure: pIYB18F1Lfq/UWtYjWH1CaKuuLc2dLHxeRwH5xO3BZsv4pMce5ETtqglUWa96TWp
   skip_symbols: true
   artifact: Nuget
   on:
     branch: release
+- provider: NuGet
+  server: https://chocolatey.org/
+  api_key:
+    secure: BbmHnhpI/e+m2xmR/5jxmOqKbQdcYG8RuF7iWT86SbCLIxPhMotbHprgBtw8dA4n
+  skip_symbols: true
+  artifact: ChocolateyInstall
+  on:
+    branch: release
 - provider: NuGet
   server: https://chocolatey.org/
   api_key:
@@ -100,7 +110,7 @@ deploy:
     branch: release
 - provider: NuGet
   api_key:
-    secure: rSx36T78ZXIqD2Tk/DatbUP05MiHgxTWjOIGquhzWeTJX0VEB4Mn2TZyi0zMtGIL
+    secure: pIYB18F1Lfq/UWtYjWH1CaKuuLc2dLHxeRwH5xO3BZsv4pMce5ETtqglUWa96TWp
   skip_symbols: true
   artifact: NugetCandidate
   on:
@@ -109,7 +119,7 @@ deploy:
   tag: $(appveyor_build_version)-rc
   release: OpenCover (Release Candidiate) $(appveyor_build_version)
   auth_token:
-    secure: thjVnm0YNqFzuRd6kLGj0bKHlPfPbRNOj3clihjeQP4MnJItTRLMogx+pC5w43Nd
+    secure: T8hG3PcjoJoYaCr7ND6wFfzJdje9TYqbvBl9pFmh3EmI6relJrXzAGAooe9lBYjt
   artifact: Installer, ZipArchive
   prerelease: true
   on:
@@ -118,7 +128,7 @@ deploy:
   tag: $(appveyor_build_version)
   release: OpenCover (Release) $(appveyor_build_version)
   auth_token:
-    secure: thjVnm0YNqFzuRd6kLGj0bKHlPfPbRNOj3clihjeQP4MnJItTRLMogx+pC5w43Nd
+    secure: T8hG3PcjoJoYaCr7ND6wFfzJdje9TYqbvBl9pFmh3EmI6relJrXzAGAooe9lBYjt
   artifact: Installer, ZipArchive
   on:
     branch: release
@@ -147,4 +157,4 @@ on_success:
        & .\build.bat dogfood-release
     }
 on_finish:
-  - ps: #$blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
+  - ps: #$blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))

build/installer.build

@@ -12,7 +12,9 @@
         <include name="Gendarme.Rules.Maintainability.dll" />
         <include name="log4net.dll" />
         <include name="log4net.config" />
+        <include name="Microsoft.Bcl.AsyncInterfaces.dll" />
         <include name="Microsoft.Extensions.Configuration.Abstractions.dll" />
+        <include name="Microsoft.Extensions.Configuration.Binder.dll" />
         <include name="Microsoft.Extensions.Configuration.dll" />
         <include name="Microsoft.Extensions.Configuration.FileExtensions.dll" />
         <include name="Microsoft.Extensions.Configuration.Json.dll" />
@@ -35,7 +37,16 @@
         <include name="Sentry.dll" />
         <include name="Sentry.PlatformAbstractions.dll" />
         <include name="Sentry.Protocol.dll" />
+        <include name="System.Buffers.dll" />
         <include name="System.Collections.Immutable.dll" />
+        <include name="System.Diagnostics.DiagnosticSource.dll" />
+        <include name="System.Memory.dll" />
+        <include name="System.Numerics.Vectors.dll" />
+        <include name="System.Runtime.CompilerServices.Unsafe.dll" />
+        <include name="System.Text.Encodings.Web.dll" />
+        <include name="System.Text.Json.dll" />
+        <include name="System.Threading.Tasks.Extensions.dll" />
+        <include name="System.ValueTuple.dll" />
       </fileset>
       <fileset basedir="${solution.folder}\bin\Release\x86" prefix="x86">
         <include name="OpenCover.Profiler.dll" />