Build and publish test container #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
changed the title
Before upgrading to SF6 and upgrading all dependencies, I opted to first upgrade the qa tooling. They will not pass by any means at this point.
We now use our own docker based devconf
If we want code coverage stats, we can use scrutenizer for that purpose
The legacy folder was renamed to openconext (as decided to be the way forward) The .env files only contained env overrides and allowed for setting the secret
That more closesly matches the modern symfony ways The webpack setup needed some small tweaking in order to keep things in a functioning state
This should have resulted in 500 errors in the tiqr app previously.
Level 8 and 9 have mostly been ignored as most of the warnings where hailing from the behat contexts
We have a test folder, but there are no tests. The folder is kept, and PHP Unit is standing by for future development where we might want to utilize PHP unit testing
By leaning on the MicroKernelTrait
Also optimized imports with it.
The form was not using the correct bootstrap form classes so was ugly
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
from
35ddce5 to
75ac460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Github action for building a test container, which will be used in behat tests