-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Reference “opencilk-language-specification” #95
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for sage-licorice-6da44d ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a7712da
to
cbf8200
Compare
Hello @dcurtisatmit do you get notified when I comment on your pull request? |
cbf8200
to
3b4ca32
Compare
Hi @dcurtisatmit I have implemented a way to display attribution to Intel and Cilk Arts. This article should credit them, so I went in myself to "flick the switch" in the CMS editor ("provide attribution to Intel and Cilk Arts"). It's also editable manually with |
6911139
to
b96d832
Compare
Changed "three" to "four" in one place.
It's taking me a while to review the entire document and take notes about issues. Here are some of my initial notes. Introduction
Grammar
Semantics (not complete)
|
I would remove the word "specification". Our goal now is not to write a spec that would allow a clean room implementation of OpenCilk. So rename the document and remove the first paragraph and bulleted list of the introduction. We don't have any special SIMD features beyond what LLVM provides so remove the first three sentences of the paragraph beginning "An implementation". Remove the last sentence of the introduction explaining the word "shall". Change the uses of "shall" later in the document from "foo shall be bar" to "foo is bar". Remove the "Related documents" section. In "Keywords for Tasking" add the cilk_reducer keyword. Remove the last sentence, which invokes the language of the C standard. Rewrite the definition of Rewrite
TB says the serialization rule is no longer true in C++ when you spawn an assignment with a side effect on the left hand side. In the "Spawn" section the examples in red show as Is the "Programmer note" under "Sync" still true in OpenCilk? |
Automatically generated by Netlify CMS