Fix some bugs with task-simplify and function inlining #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructions reachable from detach-unwind blocks.
…y reducing LLVM tests.
…ing detaches, to support serializing nested tasks.
neboat
force-pushed
the
dev/18.x-fix-tasksimplify
branch
from
c1b50ad to
01fd4f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that can occur in the task-simplify pass when serializing nested tasks. This PR addresses this crash by using a new, initial interface to dynamically maintain the TaskInfo analysis during the task-serialization process.
In addition, this PR fixes function inlining to properly inline resume statements reachable from the exceptional return of a spawned task.
Finally, this PR adjusts the task-simplify code to avoid problems that only arise when handling reduced LLVM test cases.