Increase __cilkrts_stack_frame alignment to ABI stack alignment #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inter. All the __cilkrts_stack_frame objects are aligned on the stack. There is no cost to increasing their alignment and the compiler might generate better code. This alignment is only used within a module. The runtime will use whatever value is declared in C code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the
__cilkrts_stack_frameobjects are allocated on the stack. Increasing their alignment to the ABI stack alignment might allow the compiler to generate better code. The cost is possibly allocating an extra word because the size of an object is a multiple of its alignment. This alignment is only used within a module. The runtime will use the alignment dictated by C code.On mainstream targets this will increase alignment from 8 to 16 bytes.