Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of cilk_for loops with template-type induction variables, and other fixes #221

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

neboat
Copy link
Collaborator

@neboat neboat commented Dec 4, 2023

This PR addresses the following:

  • Fix issue cilk for with loop index variable being a templated type crashes  #220 with the handling of template-type induction variables in simple cilk_for loops.
  • Simplify the code generation of simple cilk_for loops.
  • Fix warnings on macOS about redundant rpath flags.
  • Bring cilk_for loop code-generation in line with that of ordinary for loops in clang 16, with respect to loop attributes.

…op variable has a dependent type, to deduce the correct types for synthesized loop-bound computation.
…egen, including generation of mustprogress loop attribute.
@neboat neboat merged commit ffd26ee into OpenCilk:dev/16.x Dec 6, 2023
3 checks passed
@neboat neboat deleted the dev/issue220 branch January 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant