Perform memory check on files before loading them in #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the initial logic for performing a memory check. We will estimate the amount of memory loading a file will take (the estimation may be different for each file type), compare that to the available system memory, and present a warning to the user if we may end up using too much memory. This still needs some work, and we definitely want to make sure it is cross-platform. We may also want a way to disable this check, in case some users receive the warning often and don't want to see it. Signed-off-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial logic for performing a memory check.
We will estimate the amount of memory loading a file will take (the estimation may be different for each file type), compare that to the available system memory, and present a warning to the user if we may end up using too much memory.
This still needs some work, and we definitely want to make sure it is cross-platform.
We may also want a way to disable this check, in case some users receive the warning often and don't want to see it.