Leave notes about the MR that fixed the issue

This is so that when we update VTK/ParaView, we can clean up our work-arounds and not use a gradient opacity transfer function. Signed-off-by: Patrick Avery <[email protected]>
OpenChemistry · Jun 22, 2022 · 9e07ab8 · 9e07ab8
1 parent 94f0025
commit 9e07ab8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/tomviz/modules/ModuleVolume.cxx b/tomviz/modules/ModuleVolume.cxx
@@ -62,6 +62,7 @@ vtkStandardNewMacro(SmartVolumeMapper)
 {
  // NOTE: Due to a bug in vtkMultiVolume, a gradient opacity function must be
  // set or the shader will fail to compile.
+ // (likely fixed in https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8909)
  m_gradientOpacity->AddPoint(0.0, 1.0);
  connect(&HistogramManager::instance(), &HistogramManager::histogram2DReady,
  this, [=](vtkSmartPointer<vtkImageData> image,
@@ -84,6 +85,7 @@ vtkStandardNewMacro(SmartVolumeMapper)
 
  // NOTE: Due to a bug in vtkMultiVolume, a gradient opacity function must
  // be set or the shader will fail to compile.
+ // (likely fixed in https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8909)
  connect(&VolumeManager::instance(), &VolumeManager::usingMultiVolumeChanged,
  this, &ModuleVolume::updateColorMap);
 }
@@ -379,6 +381,8 @@ void ModuleVolume::updateColorMap()
  case (Module::SCALAR): {
  // NOTE: Due to a bug in vtkMultiVolume, a gradient opacity function must
  // be set or the shader will fail to compile.
+ // (likely fixed in
+ // https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8909)
  bool usingMultiVolume =
  VolumeManager::instance().usingMultiVolume(this->view());
  if (usingMultiVolume) {

diff --git a/tomviz/modules/VolumeManager.cxx b/tomviz/modules/VolumeManager.cxx
@@ -90,6 +90,8 @@ void VolumeManager::onModuleAdded(Module* module)
  viewVolumes->auxProperty->SetScalarOpacity(viewVolumes->auxOpacity);
  // NOTE: Due to a bug in vtkMultiVolume, a gradient opacity function must
  // be set or the shader will fail to compile.
+ // (likely fixed in
+ // https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8909)
  viewVolumes->auxProperty->SetGradientOpacity(
  viewVolumes->auxGradientOpacity);
  viewVolumes->auxVolume->SetProperty(viewVolumes->auxProperty);