Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDING SMOOTHNESS VIA TESSELLATION SHADERS #1688

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

perminder-17
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
@perminder-17 perminder-17 changed the title WIP: ADDING SMOOTHNESS VIA TESSELLATION SHADERS ADDING SMOOTHNESS VIA TESSELLATION SHADERS Aug 2, 2024
@perminder-17
Copy link
Contributor Author

All the work for this branch is completed successfully. Here's the result of it's working.

The main thing was to implement something like Laplacian/Gaussian smoothing to remove the artifacts. But as we moved to the algorithm we noticed that these algorithm can't be implemented via tessellation shaders. I'm not sure there's a shader construct that gives the information you'd need to do Laplace Smoothing.

So, for now, we can do use both Laplacian smoothing(at CPU) and bezier smoothing(via tessellation). Since, after this algorithm, we will have more no. of triangles, so if we apply Laplacian smoothing (maybe 1 iteration) we can have a better result that we were having without bezier smoothing.

Here's the result of my work. (you can see smooth curves instead of sharp right angles)
image

here's the maximum result we can achieve with similar or maybe a better algorithm (catmull-clark)

[BEFORE]
image

[AFTER]
image

So, the result looks excatly same. If anyone want's to test it please request the version of opengl to 4.0 (can only be tested in linux/windows not in mac because we currently lack core profile)

  defaultFormat.setVersion(4,0);
  defaultFormat.setProfile(QSurfaceFormat::CompatibilityProfile);
  defaultFormat.setOptions(QSurfaceFormat::DeprecatedFunctions);

perminder-17 and others added 5 commits August 5, 2024 06:41
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder Singh <[email protected]>
Signed-off-by: Perminder Singh <[email protected]>
Signed-off-by: Perminder Singh <[email protected]>
Signed-off-by: Perminder Singh <[email protected]>
@perminder-17
Copy link
Contributor Author

Removed the debugging pieces which was previously added for testing purpose.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Here are the build results
Avogadro2.AppImage
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants