bug fixed

[PengfeiLi0218]

bug: Mismatch between validRedirectURL and requestedRedirectURL

[chrisjsimpson]

I would advise caution on this for the following reasons:

It will break existing apitester deployments which expect the /obp route to exist
Since it's inception the apitester has used the route '/obp' for the return url, any other developers (and including documentation being made) will expect this to still be the case
It's not clear what bug this commit is fixing (I assume it's related to oauth debugging internally) but the effect of this commit is probably unintentional.
I propose there should be consistency on which route oauth apps, be recommending which route apps should delegate for their oauth returl url.
@PengfeiLi0218 @simonredfern

[chrisjsimpson]

I would advise caution on this for the following reasons:

• It will break existing apitester deployments which expect the /obp route to exist
• Since it's inception the apitester has used the route '/obp' for the return url, any other developers (and including documentation being made) will expect this to still be the case
• It's not clear what bug this commit is fixing (I assume it's related to oauth debugging internally) but the effect of this commit is probably unintentional.
• I propose there should be consistency on which route oauth apps, be recommending which route apps should delegate for their oauth returl url.

@PengfeiLi0218 @simonredfern

[karmaking]

Yeah we'd have to update API Tester configurations on all sandboxes once this gets deployed. Tedious, but IMHO increasing consistency, as none of our other apps need additions to the redirect URL.

[chrisjsimpson]

Thanks @PengfeiLi0218 @simonredfern

Please could alias the /obp route so that it still works for older deployments.

A separate issue (#48 ) has been created to RECOMMEND app developers use a standard route for their oauth return urls (I suggest /oauth_redirect and then we will put this into the development docs..