feat: Feature/floyd rebase unstable #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* floyd: refactor storage to support multi rocksdb instance && todis key format * fix compile error after rebase * fix compile error after rebase * fix by review comments * fix by review comments * fix by review comments * fix by lqx and panlei's review comments * fix by review comments * fix by review comments * fix by review comments * fix by review comments * rebase upstream code * rebase upstream code * fix storage construct error * change uint32_t ttl to uint64_t * change int() to static_cast * fix by xiaoshuai's review comments * fix compile error in debug mode * fix slot_indexer by review comments * fix by xiaoshuai's review comments * fix dynamic change ttl and periodic_seconds * define CRCU32 type * change uint64_t to int64_t to support nagative time ttl * fix cache list error in floyd * fix by yuge's review comments * change shared_ptr to unique_ptr to be consisten with pikiwidb --------- Co-authored-by: wangshaoyi <[email protected]>
Co-authored-by: wuxianrong <[email protected]>
dingxiaoshuai123
approved these changes
Feb 23, 2024
AlexStocks
approved these changes
Feb 23, 2024
AlexStocks
merged commit 0004932
into
OpenAtomFoundation:unstable
13 of 16 checks passed
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* feat: add floyd (OpenAtomFoundation#2347) * floyd: refactor storage to support multi rocksdb instance && todis key format --------- Co-authored-by: wangshaoyi <[email protected]> * fix floyd keys (OpenAtomFoundation#2364) Co-authored-by: wuxianrong <[email protected]> * floyd rebase unstable branch * fix by review comments --------- Co-authored-by: wangshaoyi <[email protected]> Co-authored-by: Mixficsol <[email protected]> Co-authored-by: wuxianrong <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* feat: add floyd (OpenAtomFoundation#2347) * floyd: refactor storage to support multi rocksdb instance && todis key format --------- Co-authored-by: wangshaoyi <[email protected]> * fix floyd keys (OpenAtomFoundation#2364) Co-authored-by: wuxianrong <[email protected]> * floyd rebase unstable branch * fix by review comments --------- Co-authored-by: wangshaoyi <[email protected]> Co-authored-by: Mixficsol <[email protected]> Co-authored-by: wuxianrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #2403