Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container exit even children process exists #665

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kamiyadm
Copy link
Collaborator

@kamiyadm kamiyadm commented Aug 27, 2024

  • make config.json/process the init process (pid=1) in container
  • make sure ll-box exec/ll-cli exec/ll-cli run work in case these command should run command in existing container

@deepin-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm
Once this PR has been reviewed and has the lgtm label, please assign black-desk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kamiyadm kamiyadm marked this pull request as draft August 27, 2024 10:58
@kamiyadm kamiyadm marked this pull request as ready for review August 28, 2024 04:05
Make bash to be the init process in container instead of ll-box.
issue: OpenAtom-Linyaps#652

Log:
Update process command.
before: bash --login -e -c 'cmd; wait'
now: bash --login -e -c "'$@ & wait' init cmd"

Log:
After bash being the init process in container, we should
find the pid of bash instead of ll-box.

Log:
@kamiyadm kamiyadm marked this pull request as draft September 3, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants