-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add industries grid component #15
add industries grid component #15
Conversation
✅ Deploy Preview for cosmic-klepon-3c693c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Change cards color to be dark purple then add card shadows. Would love to get feedback on this @abrichr . Thank you! |
@jesicasusanto I really like the shadows! Do you think the card colours should be lighter to improve visibility? |
@dianzrong thank you! i agree too. I've made the grids background lighter. |
Ready for review @abrichr @Jonathan-Sendsen. Summary :
|
Please add "(For Developers)" after "Getting Started" |
Please modify grid styles so that padding is symmetrical horizontally/vertically between items |
@jesicasusanto can you please add an icon to each one, e.g. from https://thenounproject.com/ ? 🙏 Also please separate developers into a separate section altogether, and convert the CTA buttons from primary to secondary (make them smaller / less striking) |
https://deploy-preview-15--cosmic-klepon-3c693c.netlify.app/: Can you please restore the padding / margins around "AI for Humans", "Automate your workflows", "No programming required"? What do you think about keeping the "Get Started" button, and having it scroll down to the industries grid? |
Also please feel free to implement #17 while you're at it 😄 (can be a seaprate PR, no pressure!) |
Update @abrichr :
|
Hi @abrichr for cropping the logos to content, gimp doesn't support exporting the logo back to an svg file. As an alternative, I adjusted the width and height attributes inside the svg files according to the heightxwidth sized given by the gimp "crop to content" command. Please let me know what you think of this solution. Thank you! |
Thanks @jesicasusanto ! Can you please remove the developer grid item? Then modify the "Getting Started" header to "For Developers". Let's also remove this heading altogether:
Also please rename "Freight" to "Logistics". Also, is it possible to center grid content vertically? Consider e.g. |
Update @abrichr
I also added a silver border around the cards when we hover them as you suggested on our last sprint in https://github.com/OpenAdaptAI/web/pull/15/files#diff-4130362d983b52ff81285caab923910466ada416e0ca9974ad2ffd36f674366e:~:text=%7D-,.card%3Ahover%20%7B,-border%3A%202 . But Im not sure if this aligns with your vision for the hover card animation. Would love to get a clarification in this. Looking forward to your feedback! |
Hi @jesicasusanto :
Please let me know if anything is unclear! |
@jesicasusanto the updated border color looks better, and the background color animation looks good 👍 Todo:
Please let me know if anything is unclear! |
Thank you for the feedbacks. Here are my updates @abrichr |
Resolves Issue #7
This PR
implements the industries grid component of the web page that is responsive to the screen size
fixed the zoomed in screen when first opening the web page
Before :
steps to reproduce
same as Getting Started in readme