[CLI] Add graceful error handling for unknown command #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.Description of the PR
Currently, the CLI throws an exception when an unknown command is encountered such as the following for
--help
as mentioned here: #490The uncaught exception will result in the following:
A few people have run into this as mentioned here: airlift/airline#45
This PR will return a graceful error for any unknown command by gracefully catching
io.airlift.airline.ParseArgumentsUnexpectedException
such as the following:A DWIM approach would alias
--help
tohelp
but this may lead to more issues as we may need to alias all the other commands as well to avoid confusion. This approach returns an nicer error message and encourages the user to learn the correct syntax for the CLI. However, if we decide it is better to alias, I can look into this too.