[cpackget] Handle Cookie headers in HTTP GET requests when required

[brondani]

Fixes

• Download problem with pack "Geehy::APM32A0xx_DFP" devtools#1906

Changes

• Resend HTTP GET request with a Cookie header if the first attempt fails with StatusForbidden status and a Set-Cookie among the response headers.

Checklist

• 🤖 This change is covered by unit tests as required.
• 🤹 All required manual testing has been performed.
• 🛡️ Security impacts have been considered.
• 📖 All documentation updates are complete.
• 🧠 This change does not change third-party dependencies

[codeclimate]

Code Climate has analyzed commit 5ee5cef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 72.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.6% (0.0% change).

View more on Code Climate.

[bgn42]

It is not clear to me how this can work, if the status is forbidden, how can one then send a cookie? But I don't know much about using cookies, nearly nothing. But most of them taste good :-).

[brondani]

It is not clear to me how this can work, if the status is forbidden, how can one then send a cookie?

The response to the request may have several headers regardless of the status code. Indeed in this case it has the Set-Cookie:

A new request with such cookie is accepted by the server that responds with the full expected content and status code OK: