Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error message if a pack cannot be found in current index.pidx #209

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fixed error message if a pack cannot be found in current index.pidx #209

merged 4 commits into from
Sep 6, 2023

Conversation

thorstendb-ARM
Copy link
Collaborator

see #206

@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
cmd/commands/root.go ø

📢 Thoughts on this report? Let us know!.

jkrech
jkrech previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment.

cmd/commands/init_test.go Outdated Show resolved Hide resolved
@jkrech jkrech self-requested a review September 6, 2023 11:58
jkrech
jkrech approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorstendb-ARM thorstendb-ARM merged commit 16eacad into main Sep 6, 2023
16 checks passed
@thorstendb-ARM thorstendb-ARM deleted the cpackget#206 branch September 6, 2023 12:07
@jkrech jkrech linked an issue Sep 6, 2023 that may be closed by this pull request
[cpackget] cpackget add incorrect error message in case the pack cannot be found #206
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrech jkrech jkrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cpackget] cpackget add incorrect error message in case the pack cannot be found
2 participants
@thorstendb-ARM @jkrech