Ob 8353 externalize translations config #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add custom translation paths on the application.properties file * Adapt DefaultTranslationsService.java and TranlationMangementServiceApiClient to use the added custom translation paths added
* Add translationManagementSystemEnabled check on TranslationService to skip the translationManagementServiceApiClient call if the value is false * fixed typo on TranslationManagementServiceApiClient's class name
* Add unit tests for the class TranslationService regarding the logic added
* Correct unit tests for the TranslationService * Add translation system property to the test properties file * rename the DefaultTranslationsServiceIT file
tkuzynow
reviewed
Jan 17, 2024
src/test/java/de/caritas/cob/mailservice/api/service/TranslationServiceTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Jan 17, 2024
src/test/java/de/caritas/cob/mailservice/api/service/TranslationServiceTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Jan 17, 2024
src/test/java/de/caritas/cob/mailservice/api/service/TranslationServiceTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Jan 17, 2024
src/test/java/de/caritas/cob/mailservice/api/service/TranslationServiceTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Jan 17, 2024
src/main/java/de/caritas/cob/mailservice/api/service/DefaultTranslationsService.java
Show resolved
Hide resolved
* Move getDialectSuffix method from TranslationManagementServiceApiClient to DefaultTranslationsService * Added tests to DefaultTranslationsServiceIT
* Move getDialectSuffix method from TranslationManagementServiceApiClient to DefaultTranslationsService * Added tests to DefaultTranslationsServiceIT
* Add space between the method name and "{"
|
tkuzynow
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes