Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_warning_in_flow_save #10338

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add_warning_in_flow_save #10338

wants to merge 5 commits into from

Conversation

clackhan
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@@ -703,6 +703,12 @@ def save(
"""
if isinstance(path_or_buffer, str):
path_or_buffer = Path(path_or_buffer)
if os.path.isdir(path_or_buffer) and not save_as_external_data:
path_or_buffer = path_or_buffer / "model.pt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model.of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model.of

已修改

warnings.warn(
f"The save path cannot be a dir name from oneflow-0.9.1! The system
will automatically complete it into the file name as {path_or_buffer}"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        warnings.warn(
            f"The save path cannot be a dir name from oneflow-0.9.1! The system "
            f"will automatically complete it into the file name as {path_or_buffer}"
        )

Copy link
Contributor

@levi131 levi131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了谢暄踢的两点建议外,我没有其他问题

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

CI failed when running job: cuda-module. PR label automerge has been removed

@github-actions github-actions bot removed the automerge label Oct 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Speed stats:

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

CI failed when running job: cuda-module. PR label automerge has been removed

@github-actions
Copy link
Contributor

Speed stats:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants