Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logout() when push subscription doesn't exists #1194

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/page/managers/LoginManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,20 @@ export default class LoginManager {
const pushSubModel =
await OneSignal.coreDirector.getPushSubscriptionModel();
await OneSignal.coreDirector.resetModelRepoAndCache();

// Initialize as a local User, as we don't have a push subscription to create a remote anonymous user.
if (pushSubModel === undefined) {
await UserDirector.initializeUser(true);
return;
}

// add the push subscription model back to the repo since we need at least 1 sub to create a new user
OneSignal.coreDirector.add(
ModelName.PushSubscriptions,
pushSubModel as OSModel<SupportedModel>,
false,
);
// Initialize as non-local, make a request to OneSignal to create a new anonymous user
await UserDirector.initializeUser(false);
}

Expand Down
Loading