Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Use root docker-compose.yml for vscode #1114

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 17, 2023

Description

1 Line Summary

Fix starting development docker container from VSCode.

Details

Motivation is recent versions of docker no longer consider .devcontainer/docker-compose.yml valid, so vscode can't start the container.
Solution here is just removing the specific vscode docker-compose.yml so only the root one is used. There is nothing specific needed in the vscode specific one anyway.

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Motivation is recent versions of docker no longer consider
.devcontainer/docker-compose.yml valid, so vscode can't start the
container.
Solution here is just removing the specific vscode docker-compose.yml
so only the root one is used. There is nothing specific needed in
the vscode specific one anyway.
@jkasten2 jkasten2 merged commit 4d996ff into main Oct 19, 2023
2 checks passed
@jkasten2 jkasten2 deleted the dev/fix-vscode-docker branch October 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants