Skip to content

Commit

Permalink
fix: Correct payload to unbreak open link when clicking welcome notif…
Browse files Browse the repository at this point in the history
…ication (#1207)

https://app.asana.com/0/1208719710991963/1208760940956731/f

This issue boiled down to the "Open link when clicking welcome notification"
feature not working, when you clicked the notification is opened the 'default'
URL, not the option set.

After doing a bunch of digging, I was able to confirm that we were saving that setting
and then servcing it to the SDK via the sync API.

I was then able to trace it through:

1) src/shared/helpers/EventHelper.ts (onSubscriptionChanged_showWelcomeNotification)
2) src/shared/helpers/MainHelper.ts (MainHelper.showLocalNotification)

There we shovel that url into a dataPayload that we shovel into a service worker call.

That comes out the other side when you click the notifiction in:

3) src/sw/serviceWorker/ServiceWorker.ts (onNotificationClicked)

There we cast via:

const osNotification = event.notification.data as IOSNotification;

IOSNotification is defined to have:

```
readonly launchURL?: string;
```

However, the struct we created had:

```
    const dataPayload = {
      data,
      url,
      buttons: buttons
        ? convertButtonsToNotificationActionType(buttons)
        : undefined,
    };
```

url != launchURL

Fixing the payload made it start working.
  • Loading branch information
chamons authored Nov 18, 2024
1 parent 765c6a3 commit 1d15945
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/shared/helpers/MainHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export default class MainHelper {
};
const dataPayload = {
data,
url,
launchURL: url,
buttons: buttons
? convertButtonsToNotificationActionType(buttons)
: undefined,
Expand Down

0 comments on commit 1d15945

Please sign in to comment.