optimizing code

core/SConscript.firmware

@@ -15,7 +15,7 @@ USE_THD89 = ARGUMENTS.get('USE_THD89', '0')
 FEATURE_FLAGS = {
     "RDI": True,
     "SECP256K1_ZKP": True,  # required for trezor.crypto.curve.bip340 (BIP340/Taproot)
-    "SYSTEM_VIEW": True,
+    "SYSTEM_VIEW": False,
 }
 
 CCFLAGS_MOD = ''

core/src/apps/benfen/layout.py

@@ -14,15 +14,14 @@ async def require_show_overview(
 ) -> bool:
     from trezor.strings import strip_amount
 
-    result = await should_show_details(
+    return await should_show_details(
         ctx,
         title=_(i18n_keys.TITLE__SEND_MULTILINE).format(
             strip_amount(format_benfen_amount(value, currency_symbol))[0]
         ),
         address=to_addr,
         br_code=ButtonRequestType.SignTx,
     )
-    return result
 
 
 async def require_confirm_fee(

core/src/apps/benfen/sign_tx.py

@@ -18,7 +18,10 @@
 
 
 async def process_transaction(
-    ctx, address: str, tx_bytes: bytes, coin_type: bytes
+    ctx,
+    address: str,
+    tx_bytes: bytes,
+    coin_type: bytes,
 ) -> bytes:
     parser = TransactionParser()
 

core/src/apps/benfen/tx_parser.py

@@ -273,7 +273,7 @@ def read_commands(self) -> list | None:
         return commands
 
 
-def parse_transaction_inputs(parser):
+def parse_transaction_inputs(parser) -> list[ParsedInput] | None:
     input_count = parser.read_u8()
 
     inputs = []
@@ -312,7 +312,7 @@ def parse_transaction_inputs(parser):
     return inputs
 
 
-def parse_gas_data(parser):
+def parse_gas_data(parser) -> dict | None:
     payment_count = parser.read_u8()
     payments = []
     for _ in range(payment_count):
@@ -330,7 +330,7 @@ def parse_gas_data(parser):
     return {"payment": payments, "owner": owner, "price": price, "budget": budget}
 
 
-def parse_transaction_expiration(parser):
+def parse_transaction_expiration(parser) -> dict | None:
     expiration_type = parser.read_u8()
     if expiration_type == 0:
         return {"type": "None", "value": None}
@@ -341,7 +341,7 @@ def parse_transaction_expiration(parser):
         return None
 
 
-def parse_transaction(hex_data):
+def parse_transaction(hex_data) -> dict | None:
     try:
         data = binascii.unhexlify(hex_data)
         parser = BCSParser(data)
@@ -388,7 +388,7 @@ def parse_transaction(hex_data):
 
 
 class TransactionParser:
-    def parse_tx(self, tx_hex):
+    def parse_tx(self, tx_hex) -> dict | None:
         try:
             if isinstance(tx_hex, bytes):
                 tx_hex = binascii.hexlify(tx_hex).decode()