Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babylon cosmos provider example #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: babylon cosmos provider example #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/versionInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

const version = '2.2.7-alpha.2';
const version = '2.2.7-alpha.3';
const versionBuild = '2020-0101-1';

export default {
Expand Down
6 changes: 6 additions & 0 deletions packages/example/chains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ export const registeredChains: IChainInfo[] = [
href: '/aptosMartian',
icon: 'https://uni.onekey-asset.com/static/chain/apt.png',
},
{
id: uuid.v4(),
name: 'Babylon',
href: '/babylon',
icon: 'https://uni.onekey-asset.com/static/logo/babylon.png',
},
{
id: uuid.v4(),
name: 'Benfen',
Expand Down
10 changes: 10 additions & 0 deletions packages/example/components/chains/babylon/dapps.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export const dapps = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Add TypeScript interface for dApp configuration

Define an interface for better type safety and documentation.

+interface DApp {
+  name: string;
+  url: string;
+}
+
-export const dapps = [
+export const dapps: DApp[] = [
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export const dapps = [
interface DApp {
name: string;
url: string;
}
export const dapps: DApp[] = [

{
name: 'Osmosis',
url: 'https://app.osmosis.zone/',
},
{
name: 'JunoSwap',
url: 'https://junoswap.com/',
},
];
Loading
Loading