-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid rendering floating icons within iframes. #272
Conversation
概述浏览此更改修改了 变更
序列图sequenceDiagram
participant W as Window
participant F as FloatingButton
W->>F: injectFloatingButton()
alt Is Top Window
F-->>W: Inject Floating Button
else Is Iframe
F-->>W: Early Return, No Injection
end
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/providers/inpage-providers-hub/src/floatingButton/index.tsx
(1 hunks)
🔇 Additional comments (1)
packages/providers/inpage-providers-hub/src/floatingButton/index.tsx (1)
742-745
: 代码变更看起来不错!
这个 iframe 检查的实现很好,可以有效防止浮动按钮在 iframe 中渲染。这是一个很好的安全实践。
Summary by CodeRabbit