Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint #258

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: lint #258

merged 1 commit into from
Nov 27, 2024

Conversation

ByteZhang1024
Copy link
Contributor

@ByteZhang1024 ByteZhang1024 commented Nov 27, 2024

Summary by CodeRabbit

  • 新功能

    • ProviderTon 类中添加了 restoreConnection 方法,以便重新建立连接。
    • 引入了 TonRequestJsBridgeRequest 类型,以增强异步方法的类型安全性。
  • 改进

    • 更新了 connect 方法的实现,增强了连接请求的处理能力和错误处理。
    • 改进了事件处理机制,确保提供者准确反映当前连接状态。
  • 错误修复

    • 增强了错误处理,确保在链 ID 不匹配和未知签名者地址时抛出适当错误。

Copy link

coderabbitai bot commented Nov 27, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次变更主要集中在三个文件中,涉及类型调整和方法签名更新。OnekeyCosmosProvider.ts 文件更新了多个方法的签名,以提高类型安全性和一致性。cosmjs.ts 文件新增了两个类,分别实现了不同的签名接口。OnekeyTonProvider.ts 文件则增强了 ProviderTon 类的功能,添加了新的方法和类型定义,并改进了错误处理和事件管理。

Changes

文件路径 更改摘要
packages/providers/onekey-cosmos-provider/src/OnekeyCosmosProvider.ts 更新 IProviderCosmos 接口中的 signDirectsendTxgetKeysignEthereum 方法的签名,增强类型一致性。添加 ESLint 禁用注释。
packages/providers/onekey-cosmos-provider/src/cosmjs.ts 新增 CosmJSOfflineSignerOnlyAminoCosmJSOfflineSigner 类,实现不同的签名接口,增强签名功能和错误处理。
packages/providers/onekey-ton-provider/src/OnekeyTonProvider.ts 新增 TonRequestJsBridgeRequest 类型,更新 ProviderTon 类,添加 restoreConnection 方法,改进连接和事件处理。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProviderCosmos
    participant CosmJSOfflineSigner
    participant ProviderTon

    User->>ProviderCosmos: signDirect(...)
    ProviderCosmos->>User: Promise<DirectSignResponse>

    User->>CosmJSOfflineSigner: sign(...)
    CosmJSOfflineSigner->>ProviderCosmos: signDirect(...)
    ProviderCosmos->>CosmJSOfflineSigner: Promise<DirectSignResponse>
    CosmJSOfflineSigner->>User: Promise<DirectSignResponse>

    User->>ProviderTon: connect(...)
    ProviderTon->>User: Promise<ConnectEvent>
Loading

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ByteZhang1024 ByteZhang1024 enabled auto-merge (squash) November 27, 2024 12:19
@ByteZhang1024 ByteZhang1024 merged commit 37fa103 into master Nov 27, 2024
4 of 6 checks passed
@ByteZhang1024 ByteZhang1024 deleted the fix/lint branch November 27, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants