Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aptos isConnected on Ext #250

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix: aptos isConnected on Ext #250

merged 2 commits into from
Nov 12, 2024

Conversation

ByteZhang1024
Copy link
Contributor

@ByteZhang1024 ByteZhang1024 commented Nov 12, 2024

Summary by CodeRabbit

  • 新特性
    • 更新多个包的版本号至 2.1.14,包括 @onekeyfe/cross-inpage-provider-core@onekeyfe/cross-inpage-provider-errors@onekeyfe/cross-inpage-provider-types 等。
  • 修复
    • 修复了依赖项版本不一致的问题,确保所有相关包均更新至最新版本。

Copy link

coderabbitai bot commented Nov 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改主要涉及多个软件包的 package.json 文件版本更新。所有相关软件包的版本号均从 2.1.13 增加到 2.1.14。同时,多个依赖项的版本也进行了相应更新,确保它们与主软件包版本一致。整体结构、脚本和其他字段未发生变化。

Changes

文件路径 更改摘要
packages/core/package.json 版本从 2.1.13 更新到 2.1.14;依赖项版本更新至 2.1.14
packages/desktop/desktop-bridge-injected/package.json 版本从 2.1.13 更新到 2.1.14;依赖项版本更新至 2.1.14
packages/empty/package.json 版本从 2.1.13 更新到 2.1.14
packages/errors/package.json 版本从 2.1.13 更新到 2.1.14
packages/events/package.json 版本从 2.1.13 更新到 2.1.14
packages/example/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/extension/extension-bridge-hosted/package.json 版本从 2.1.13 更新到 2.1.14;依赖项版本更新至 2.1.14
packages/extension/extension-bridge-injected/package.json 版本从 2.1.13 更新到 2.1.14;依赖项版本更新至 2.1.14
packages/injected/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/native/native-bridge-injected/package.json 版本从 2.1.13 更新到 2.1.14;依赖项版本更新至 2.1.14
packages/providers/inpage-providers-hub/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-algo-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-alph-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-aptos-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-btc-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-cardano-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-conflux-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-cosmos-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-eth-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-near-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-nostr-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-polkadot-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-private-external-account-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-private-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-scdo-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-solana-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-sui-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-ton-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-tron-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/providers/onekey-webln-provider/package.json 版本从 2.1.13 更新到 2.1.14;多个依赖项版本更新至 2.1.14
packages/types/package.json 版本从 2.1.13 更新到 2.1.14
packages/webview/package.json 版本从 2.1.13 更新到 2.1.14;依赖项版本更新至 2.1.14
packages/providers/onekey-aptos-provider/src/OnekeyAptosProvider.ts 修改了连接和断开事件的处理逻辑,简化了事件发射的条件检查。

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Report too large to display inline

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@ByteZhang1024 ByteZhang1024 merged commit a834c72 into master Nov 12, 2024
5 of 7 checks passed
@ByteZhang1024 ByteZhang1024 deleted the fix/aptosIsConnect branch November 12, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants