refactor: replace asmcrypto.js with native crypto module #6550

sidmorizon · 2025-01-19T12:59:22Z

No description provided.

- Remove asmcrypto.js dependency usage - Replace with native Node.js crypto module implementations - Maintain same function signatures and behavior - All tests passing with identical snapshots Co-Authored-By: [email protected] <[email protected]>

codesandbox · 2025-01-19T12:59:24Z

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

coderabbitai · 2025-01-19T12:59:28Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-01-19T12:59:35Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	43.9 kB	lgbot
npm/[email protected]	None	`0`	71.5 kB	brentvatne
npm/[email protected]	None	`0`	45.8 kB	tectiv3

🚮 Removed packages: npm/@polkadot/[email protected], npm/@polkadot/[email protected], npm/@polkadot/[email protected], npm/@polkadot/[email protected], npm/@polkadot/[email protected], npm/@polkadot/[email protected]

View full report↗︎

sidmorizon · 2025-01-19T13:00:07Z

apps/mobile/package.json

@@ -30,6 +30,7 @@
    "@formatjs/intl-getcanonicallocales": "^1.9.2",
    "@formatjs/intl-locale": "^2.4.47",
    "@formatjs/intl-pluralrules": "^4.3.3",
+    "@metamask/react-native-aes-crypto": "1.2.2",


sidmorizon · 2025-01-19T13:00:11Z

apps/mobile/package.json

@@ -54,6 +55,7 @@
    "expo-barcode-scanner": "12.9.3",
    "expo-blur": "12.9.1",
    "expo-clipboard": "5.0.1",
+    "expo-crypto": "14.0.2",


sidmorizon · 2025-01-19T14:10:52Z

packages/core/src/secret/__tests__/secret.test.ts

@@ -851,7 +855,7 @@ describe('Secret Module Tests', () => {
          privateKeys[index].extendedKey.key,
        );
      });
-    });
+    }, 10_000);


异步改造后，派生公钥方法执行时间过长，需用 Promise.all 优化

devin-ai-integration bot and others added 10 commits January 19, 2025 04:06

fix: lint

8ad91a5

fix: lint

df59c66

fix: lint

95e3be2

fix: lint

af4d9fd

fix: lint

51458d4

fix: unit tests

4a6d72c

fix: lint

5e3d2d9

fix: lint

063d52f

fix: unit tests

84c538f

sidmorizon commented Jan 19, 2025

View reviewed changes

sidmorizon added 4 commits January 19, 2025 21:31

fix: unit test

ca96fe6

fix: unit tests

1611d65

fix: lint

fbe1c46

fix: lint

0a33725

sidmorizon commented Jan 19, 2025

View reviewed changes

sidmorizon added 3 commits January 19, 2025 22:29

fix: unit test

67c5dac

fix: lint

82a7419

fix: lint

7eb3d90

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: replace asmcrypto.js with native crypto module #6550

refactor: replace asmcrypto.js with native crypto module #6550

sidmorizon commented Jan 19, 2025

codesandbox bot commented Jan 19, 2025

coderabbitai bot commented Jan 19, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

socket-security bot commented Jan 19, 2025 •

edited

Loading

sidmorizon Jan 19, 2025

sidmorizon Jan 19, 2025

sidmorizon Jan 19, 2025 •

edited

Loading

refactor: replace asmcrypto.js with native crypto module #6550

Are you sure you want to change the base?

refactor: replace asmcrypto.js with native crypto module #6550

Conversation

sidmorizon commented Jan 19, 2025

codesandbox bot commented Jan 19, 2025

Review or Edit in CodeSandbox

coderabbitai bot commented Jan 19, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

socket-security bot commented Jan 19, 2025 • edited Loading

sidmorizon Jan 19, 2025

Choose a reason for hiding this comment

sidmorizon Jan 19, 2025

Choose a reason for hiding this comment

sidmorizon Jan 19, 2025 • edited Loading

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Jan 19, 2025 •

edited

Loading

sidmorizon Jan 19, 2025 •

edited

Loading