Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: sol sign message OK-34533 #6420

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Feat: sol sign message OK-34533 #6420

merged 4 commits into from
Dec 31, 2024

Conversation

ByteZhang1024
Copy link
Contributor

No description provided.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Dec 30, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ByteZhang1024 ByteZhang1024 enabled auto-merge (squash) December 30, 2024 10:24
@ByteZhang1024 ByteZhang1024 marked this pull request as draft December 30, 2024 10:34
auto-merge was automatically disabled December 30, 2024 10:34

Pull request was converted to draft

@ByteZhang1024 ByteZhang1024 marked this pull request as ready for review December 30, 2024 23:17
@sidmorizon sidmorizon enabled auto-merge (squash) December 31, 2024 02:33
@sidmorizon sidmorizon merged commit 9172da1 into x Dec 31, 2024
8 checks passed
@sidmorizon sidmorizon deleted the feat/solSignMessage branch December 31, 2024 02:47
ByteZhang1024 added a commit that referenced this pull request Dec 31, 2024
@ByteZhang1024
Feat: sol sign message OK-34533 (#6420)
498a5df 
* feat: sol sign message on headware

* feat: update hardware sdk version

* chore: fix lint

* optimize: sol sign message format
ByteZhang1024 added a commit that referenced this pull request Jan 2, 2025
@ByteZhang1024
Revert "Feat: sol sign message OK-34533 (#6420)"
ff23d2d 
This reverts commit 498a5df.
originalix added a commit that referenced this pull request Jan 3, 2025
@originalix @huhuanming
@weatherstar @ByteZhang1024 @sidmorizon
chore: Update main branch with v5.5.1 changes (#6437)
101f26d 
* Update .env.version

* fix: fix the issue where the account selector does not work in the market module. (#6414)

* style: modify the background color and hover color of TradingView's indicator. (#6415)

* fix: several sentry issues (#6426)

* fix: sqlite limit (#6425)

* chore: add requestId on sentry xhr breadcrumb (#6427)

* fix: qr psbt compare (#6428)

(cherry picked from commit d89b918)

* feat: Add DTC network (#6431)

* Feat: sol sign message OK-34533 (#6420)

* feat: sol sign message on headware

* feat: update hardware sdk version

* chore: fix lint

* optimize: sol sign message format

* chore: update js sdk 1.0.17 (#6432)

* fix: fix the crash when copying in iCloud sync on iOS. (#6433)

* Update react-native+0.73.7.patch

* Update react-native+0.73.7.patch

* Optimize/kaspa transfer OK-34592 (#6423)

* feat: optimize kaspa transfer

* optimize: hardware transafer kas

* Revert "Feat: sol sign message OK-34533 (#6420)"

This reverts commit 498a5df.

* fix: fix the issue of using a mismatched derviceType when creating an address.

* fix: fix deriveType type

* feat: Add sonic network (#6435)

* chore: update version

---------

Co-authored-by: huhuanming <[email protected]>
Co-authored-by: weatherstar <[email protected]>
Co-authored-by: ByteZhang <[email protected]>
Co-authored-by: morizon <[email protected]>
originalix added a commit that referenced this pull request Jan 10, 2025
@originalix @huhuanming
@weatherstar @ByteZhang1024 @sidmorizon
chore: Sync main branch with v5.5.2 (#6483)
33e0760 
* Update .env.version

* fix: fix the issue where the account selector does not work in the market module. (#6414)

* style: modify the background color and hover color of TradingView's indicator. (#6415)

* fix: several sentry issues (#6426)

* fix: sqlite limit (#6425)

* chore: add requestId on sentry xhr breadcrumb (#6427)

* fix: qr psbt compare (#6428)

(cherry picked from commit d89b918)

* feat: Add DTC network (#6431)

* Feat: sol sign message OK-34533 (#6420)

* feat: sol sign message on headware

* feat: update hardware sdk version

* chore: fix lint

* optimize: sol sign message format

* chore: update js sdk 1.0.17 (#6432)

* fix: fix the crash when copying in iCloud sync on iOS. (#6433)

* Update react-native+0.73.7.patch

* Update react-native+0.73.7.patch

* Optimize/kaspa transfer OK-34592 (#6423)

* feat: optimize kaspa transfer

* optimize: hardware transafer kas

* Revert "Feat: sol sign message OK-34533 (#6420)"

This reverts commit 498a5df.

* fix: fix the issue of using a mismatched derviceType when creating an address.

* fix: fix deriveType type

* chore: update 5.5.2

* fix: fix the issue where pressing Enter would trigger paste in some forms. (#6471)

* fix: fix the issue where the screen module in Electron is loaded prematurely with a low probability. (#6473)

* Update .env.version

* fix: fix the issue where the screen module in Electron is loaded prematurely with a low probability.

---------

Co-authored-by: Leon <[email protected]>

* fix: Correct Lighting withdrawal invoice amount (#6476)

* Revert "fix: fix the issue where the screen module in Electron is loaded prematurely with a low probability. (#6473)"

This reverts commit f99ade3.

* chore: prohibit the use of the screen module in Electron Sentry.

---------

Co-authored-by: huhuanming <[email protected]>
Co-authored-by: weatherstar <[email protected]>
Co-authored-by: ByteZhang <[email protected]>
Co-authored-by: morizon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuincySx QuincySx QuincySx left review comments

@originalix originalix originalix approved these changes

@sidmorizon sidmorizon sidmorizon approved these changes

@ezailWang ezailWang Awaiting requested review from ezailWang ezailWang is a code owner

@loatheb loatheb Awaiting requested review from loatheb loatheb is a code owner

@huhuanming huhuanming Awaiting requested review from huhuanming huhuanming is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ByteZhang1024 @sidmorizon @QuincySx @originalix