-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add encryptStringAsync + refactor calls #6402
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
The lint failures are occurring in |
Changes
encryptStringAsync
function for asynchronous string encryptionallowRawPassword
to encryption interfacesBuffer.isBuffer()
andBuffer.from()
Testing
Known Issues
There are lint errors in
packages/shared/src/locale/json/vi.json
that are unrelated to these encryption function changes. These JSON formatting issues should be tracked and fixed separately as they are part of the localization system, not the encryption functionality.Link to Devin run: https://app.devin.ai/sessions/da593e3262074ed8a75fbbdf4ca98efd