-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: batch estimate fee error fallback OK-34516 #6401
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
概述演练此次更改主要针对 变更
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx (1)
Line range hint
111-134
: 批量估算回退逻辑很稳健。
捕获异常后调用 handleConfirmMultiTxsOnHwOrExternal(undefined),避免重复代码可考。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx
(4 hunks)
🔇 Additional comments (4)
packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx (4)
13-17
: 导入新类型很棒,增强可读性。
简洁且易懂。类型声明更清晰了。
37-54
: 添加对 undefined 参数的支持,逻辑更灵活。
请确保调用方都正确处理 undefined。建议加额外的判空测试。
55-56
: 设置 prevTxFeeInfo,保留之前的费用信息。
这让多笔交易的费用衔接更顺畅。
94-96
: 更新 prevTxFeeInfo 时机很好,用最新的费率信息。
确保 result[0].feeInfo 必定满足期望格式。
Summary by CodeRabbit