Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support batch estimate fee through tenderly on hw OK-34493 #6399

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

weatherstar
Copy link
Contributor

@weatherstar weatherstar commented Dec 23, 2024

Summary by CodeRabbit

  • 新功能

    • 增加了对交易费用信息的支持,允许更灵活地处理交易数据。
    • 新增了 SendConfirmFromSwap 组件,用于处理交换交易的确认过程。
    • 扩展了路由配置,新增了 SendConfirmFromSwap 路由。
  • 改进

    • 更新了 SendConfirmActionsContainer 组件的导航逻辑,增加了对 popStack 属性的支持。
    • TxFeeContainer 组件中简化了费用估算逻辑,优化了单个交易的费用信息获取。
  • 文档

    • 更新了类型定义,增加了新的费用信息类型 IFeesInfoUnit

Copy link

codesandbox bot commented Dec 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Caution

Review failed

The pull request is closed.

概述

演练

此次更改主要涉及交易确认和费用处理流程的增强。新增了 SendConfirmFromSwap 组件,扩展了发送交易的路由和类型定义。引入了 IFeesInfoUnit 类型,提供了更灵活的费用信息处理方式。同时,对导航逻辑和费用估算进行了优化,增加了更多的控制和灵活性。

变更

文件路径 变更摘要
packages/core/src/types/coreTypesTx.ts 新增 IFeesInfoUnit 类型导入,更新 IUnsignedTxPro 类型的 feesInfo 属性
packages/kit/src/hooks/useSendConfirm.ts 根据 isInternalSwap 动态确定导航目标路由
packages/kit/src/views/Send/pages/SendConfirm/* 新增 popStack 参数,优化导航堆栈控制
packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx 新增处理交易确认的专用组件
packages/shared/src/routes/send.ts 新增 SendConfirmFromSwap 路由和相关参数
packages/shared/types/fee.ts 新增 IFeesInfoUnit 类型定义

序列图

sequenceDiagram
    participant User
    participant SwapComponent
    participant SendConfirmFromSwap
    participant NavigationStack
    
    User->>SwapComponent: 触发交换
    SwapComponent->>SendConfirmFromSwap: 传递交易信息
    SendConfirmFromSwap->>NavigationStack: 导航到确认页面
    SendConfirmFromSwap->>SendConfirmFromSwap: 处理费用估算
    SendConfirmFromSwap->>NavigationStack: 根据交易结果导航
Loading

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c70803 and a11ff12.

📒 Files selected for processing (11)
  • packages/core/src/types/coreTypesTx.ts (2 hunks)
  • packages/kit/src/hooks/useSendConfirm.ts (2 hunks)
  • packages/kit/src/views/Developer/pages/Gallery/Components/stories/Toast.tsx (1 hunks)
  • packages/kit/src/views/Send/pages/SendConfirm/SendConfirmActionsContainer.tsx (4 hunks)
  • packages/kit/src/views/Send/pages/SendConfirm/SendConfirmContainer.tsx (3 hunks)
  • packages/kit/src/views/Send/pages/SendConfirm/TxFeeContainer.tsx (3 hunks)
  • packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx (1 hunks)
  • packages/kit/src/views/Send/router/index.ts (2 hunks)
  • packages/kit/src/views/Swap/hooks/useSwapBuiltTx.ts (0 hunks)
  • packages/shared/src/routes/send.ts (2 hunks)
  • packages/shared/types/fee.ts (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@weatherstar weatherstar enabled auto-merge (squash) December 23, 2024 08:48
@weatherstar weatherstar merged commit 736d593 into x Dec 23, 2024
7 of 8 checks passed
@weatherstar weatherstar deleted the fix/swap-build-toSend-opt branch December 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants