OK-34490: Fix EIP-1559 support detection for custom networks

[originalix]

Summary by CodeRabbit

• 新功能
  • 改进了EIP-1559费用支持检查的方法，增强了错误处理和控制流。
  • 现在返回一个对象，指示EIP-1559费用支持的状态。

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[coderabbitai]

概述

演练

在 ClientEvm.ts 文件中，checkEIP1559Support 方法的实现发生了变化。新的实现更加健壮，通过详细的条件检查来确定 EIP-1559 费用支持。方法现在不仅检查 baseFeePerGas，还会尝试调用 eth_maxPriorityFeePerGas 来验证最大优先级费用的支持情况。

变更

文件	变更摘要
packages/kit-bg/src/vaults/impls/evm/sdkEvm/ClientEvm.ts	重构 checkEIP1559Support 方法，改进 EIP-1559 支持检测逻辑

序列图

sequenceDiagram
    participant Client as ClientEvm
    participant RPC as Ethereum RPC
    
    Client->>RPC: 检查 baseFeePerGas
    alt baseFeePerGas 无效
        Client-->>Client: 返回 isEIP1559FeeEnabled: false
    else baseFeePerGas 有效
        Client->>RPC: 调用 eth_maxPriorityFeePerGas
        alt 调用成功
            Client-->>Client: 返回 isEIP1559FeeEnabled: true
        else 调用失败
            Client-->>Client: 返回 isEIP1559FeeEnabled: false
        end
    end

Loading

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a326f1 and a85164f.

📒 Files selected for processing (1)

• packages/kit-bg/src/vaults/impls/evm/sdkEvm/ClientEvm.ts (1 hunks)

🔇 Additional comments (2)

packages/kit-bg/src/vaults/impls/evm/sdkEvm/ClientEvm.ts (2)

31-35: 基础费用验证逻辑正确

代码正确处理了 baseFeePerGas 为 NaN 或 0 的情况，这符合 EIP-1559 的规范。

---

44-44: 返回值逻辑清晰

返回值直接使用 maxPriorityFeeSupported 作为判断依据，逻辑简洁明了。