fix: Update SCDO accountChanged event parameters

[originalix]

Summary by CodeRabbit

• 新特性

  • 简化了账户通知数据结构，直接返回第一个账户或空字符串。
  • 增强了账户请求的错误处理，确保在出错时返回空数组。
  • 更新了账户获取方法以保持一致的返回类型。
  • 添加了交易签名过程中的地址有效性检查。

• 错误修复

  • 改进了多个方法的错误处理，确保在特定情况下不会抛出错误。

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[coderabbitai]

概述

代码变更总览

本次变更主要针对 packages/kit-bg/src/providers/ProviderApiScdo.ts 文件中的 ProviderApiScdo 类进行了多处修改，重点关注错误处理和数据结构简化。

变更详情

文件路径	变更摘要
packages/kit-bg/src/providers/ProviderApiScdo.ts	- 优化 notifyDappAccountsChanged 方法的参数处理 - 改进 scdo_requestAccounts 的异常捕获 - 更新 scdo_getAccounts 方法的返回值逻辑 - 增强 _rpcCall 方法的错误处理

主要变更点

1. notifyDappAccountsChanged 方法：

   • 简化账户信息的数据结构
   • 直接返回第一个账户或空字符串

2. scdo_requestAccounts 方法：

   • 添加异常捕获机制
   • 发生错误时返回空数组

3. _rpcCall 方法：

   • 增加 networkId 验证
   • 缺失时抛出 OneKeyInternalError

4. 交易相关方法：

   • 增加地址有效性校验
   • 完善错误处理逻辑

这些变更旨在提高代码的健壮性和错误处理能力，同时简化了数据处理流程。

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a326f1 and 6c9272a.

📒 Files selected for processing (1)

• packages/kit-bg/src/providers/ProviderApiScdo.ts (1 hunks)

🔇 Additional comments (1)

packages/kit-bg/src/providers/ProviderApiScdo.ts (1)

42-42: 账户变更事件参数结构优化

参数结构简化是个好的改进，使用空字符串作为默认值也很合理。建议：

1. 验证此更改是否符合 SCDO 提供商的规范
2. 确保所有使用此事件的 dApp 都能正确处理新的参数格式

✅ Verification successful

账户变更事件参数格式统一且合理

根据代码分析，此改动是合理的：

1. 与其他提供商（如 Tron、Conflux）相比，SCDO 的参数格式更简单直接
2. 使用 accounts?.[0] ?? '' 确保了在无账户时返回空字符串，避免了 undefined
3. 这种简化的格式有助于提高兼容性和可维护性

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 搜索代码库中使用 wallet_events_accountsChanged 的地方
rg "wallet_events_accountsChanged" -A 5 -B 5

Length of output: 5351

---

Script:

#!/bin/bash
# 搜索 SCDO 相关的账户获取方法实现
ast-grep --pattern 'scdo_getAccounts($_) {
  $$$
}'

# 搜索 SCDO 相关的规范或文档
fd -e md -e txt . | xargs rg -i "scdo|provider|account.*changed" -A 3 -B 3

Length of output: 130

---

Script:

#!/bin/bash
# 搜索 SCDO 相关的账户获取方法实现，使用更宽松的模式
ast-grep --pattern 'class $_ {
  $$$
  scdo_getAccounts$$$
  $$$
}'

# 搜索 SCDO 相关的代码实现
rg "class.*ProviderApiScdo" -A 20

Length of output: 1754

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.