Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the navigation when a notification is clicked(OK-32655) #5912

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

huhuanming
Copy link
Contributor

@huhuanming huhuanming commented Sep 24, 2024

Summary by CodeRabbit

  • 新功能
    • 改进了模态导航逻辑,采用新的导航方式以提升用户体验。

Copy link

codesandbox bot commented Sep 24, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

coderabbitai bot commented Sep 24, 2024

Walkthrough

此次更改涉及 notificationsUtils.ts 文件中的导航逻辑,主要是对模态导航处理方式的修改。新增了从 @react-navigation/native 导入的 StackActions。原先直接调用导航引用的 navigate 方法来推送模态的实现被替换为创建一个 pushAction,并将其分发到导航引用。这种变化改变了模态导航的处理方式,从直接导航调用转变为分发的动作。

Changes

文件路径 更改摘要
packages/shared/src/utils/... 修改模态导航逻辑,新增 StackActions 导入,使用 StackActions.push 替代直接调用 navigate 方法。

Assessment against linked issues

Objective Addressed Explanation
推送 - 当前在通知列表页面,再点击系统通知后,通知列表内容无法点击 (OK-32655)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@huhuanming huhuanming changed the title fix: fix the navigation when a notification is clicked fix: fix the navigation when a notification is clicked(OK-32655) Sep 24, 2024
@huhuanming huhuanming enabled auto-merge (squash) September 25, 2024 00:55
@huhuanming huhuanming disabled auto-merge September 25, 2024 00:55
@huhuanming huhuanming enabled auto-merge (squash) September 25, 2024 00:55
@huhuanming huhuanming merged commit 15075a3 into x Sep 25, 2024
5 checks passed
@huhuanming huhuanming deleted the notification-navigation branch September 25, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants