Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the Trigger and Close from the Popover because of gesture conflict #3683

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: Remove the Trigger and Close from the Popover because of gesture conflict #3683

merged 1 commit into from
Oct 23, 2023

Conversation

hellohublot
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Oct 20, 2023

PR Summary

  • Introduction of onOpenChange Prop
    The Popover component was updated to include a new property known as onOpenChange. This allows for more fine-grained control over how the component responds to changes in its open state. To work with this new property, an IconButton was also added with a trigger event upon press.

  • Update to PopoverGallery Component
    The PopoverGallery component was revised to utilize the new onOpenChange property, alongside setIsOpen state management for controlling the open status of the popover. The previously used open property was replaced with isOpen for a more consistent naming convention. Additionally, the previously used Popover.Close component was replaced with a simpler Button component that adjusts isOpen to false upon being pressed. These changes ultimately aim to provide clearer and easier handling of the popover’s open state.

@hellohublot hellohublot changed the title Remove the Trigger and Close from the Popover because of gesture conflict fix: Remove the Trigger and Close from the Popover because of gesture conflict Oct 20, 2023
@hellohublot hellohublot merged commit bfefba4 into OneKeyHQ:x Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants