Skip to content

Commit

Permalink
Merge pull request #1 from OneIdentity/bugfix/noproxy
Browse files Browse the repository at this point in the history
bugfix: do not use HTTPS proxy for contacting SPP by default
  • Loading branch information
krajorama authored Jul 1, 2021
2 parents f0c4647 + 667f557 commit d0a21fb
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions default.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
# Useful for stopping users from connecting from a local network.
; exclude_networks=10.0.0.0/8, 192.168.0.0/16

# To use the system https proxy, set 'use_https_proxy=yes'
# Otherwise it is assumed that SPP can be reached directly.
use_https_proxy=no

[credential_store]
# Name of the local credential store configured in SPS for hosting sensitive
# configuration data. For more information, read the "Store sensitive
Expand Down
6 changes: 6 additions & 0 deletions plugin/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ def spp_auth_provider(self):
(username, domain) = split_username(self.username)
return domain if domain else 'Local'

def set_https_proxy(self):
if self.plugin_configuration.getboolean('plugin', 'use_https_proxy', False):
super().set_https_proxy()
else:
self.logger.info("HTTPS proxy server configuration ignored, communicating directly")

def do_authenticate(self):
self.session_cookie.setdefault("SessionId", self.connection.session_id)

Expand Down

0 comments on commit d0a21fb

Please sign in to comment.