Sync repo from v92 to v92 20240115102537

.commit

@@ -1 +1 @@
-63ec9588d63d45894c41df94a24a80ea7a52443b
+72263e1e785f6bb27749e14a97259fed6a2ecf8d

README.md

@@ -3,6 +3,44 @@
 # Identity Manager HTML5 applications
 
 ## Change log
+### January 16, 2024
+The v92 branch has been updated with fixes for the following issues.
+- Bug 441844: In Filter Data sidesheet, within Custom Filters, picking a different limited value does not cause the form to be submittable
+- Bug 441185: Exception when trying to add entitlements to a role
+- Bug 427186: Exporting table views: "Export Data"-SideSheet: Names of columns to export ignores the user interface setting "Use profile language"=OFF
+- Bug 436033: Extra word in the no-data message for Archived Requests
+- Bug 439550: Tiles no longer update the number of open items
+- Bug 441967: Requests: Product bundles: Changes to product bundles are applied to overview table without saving 
+- Bug 439915: New request: Product bundles: Filter icon and search bar displayed incorrectly/cut
+- Bug 433912: In Edit Identity sidesheet, within Rule Violations tab, upon searching, filtering or paging, the data table gets more and more columns
+- Bug 441745: Search by keywords: Unnecessary space before colon
+- Bug 441753: User interface settings: When clicking on "Reset" not the default theme will be applied, but the Device Theme
+- Bug 441217: Github bug: Custom theming is ignored by default config parameter
+- Bug 441754: Manually reloading page resets the theme
+- Bug 441167: Compliance rules: Rule violations: Buttons are displayed although identity has no permission to decide
+- Bug 441122: Sorting: "Search" is not translated
+- Bug 441320: Inactive identities listed in "My Direct Reports" start page tile but not if you follow the "VIEW" link of that tile
+- Bug 440754: Compliance Rules: Defining filters on "View Compliance Rule Details sidesheet" also applies filter to "Compliance Rules" page; results in bugged out Material Chips and JS errors (TypeError: e is undefined)
+- Bug 440143: Grouping a data table, after additional columns were added, results in 400 Bad Request in most pages
+- Bug 441161: The "No Product Bundle Selected" information disappear 
+- Bug 439720: Drop-down CDR editor clears itself too easily
+- Bug 440478: HTML5-Web: Missing scrollbar in View Attestation Run Details\Attestors in OneIM 9.2.0 (issue does not exist in 9.1.1)
+- Bug 440952: Requests: Pending requests: Useless information in details of a request
+- Bug 439739: Duplicate service categories on the request page
+- Bug 441943: Logs - Time filter LDS key is wrong
+- Bug 441975: Chip container of Datasource-Toolbar is displayed in the same row together with search box and buttons
+- Bug 442118: Parameter filter tree does not work
+- Bug 442119: Changed permission notification: Several errors when clicking notification
+- Bug 439266: Data Explorer doesn't open
+- Bug 440720: Compliance Rules with custom view set as default - TypeError: Cannot read properties of undefined (reading 'headerCell')
+- Bug 326746: Application Governance: Cannot change publish state of automatically assigned entitlements
+- Bug 442711: Exception after closing filter: TypeError: Cannot read properties of undefined (reading 'dirty')
+- Bug 443104: In DataSource Toolbar, for grouped results, changing the column order results in seemingly arbitrary column ordering
+- Bug 439914: New request: Product bundles: Product bundle selection: Custom filters not working
+- Product Backlog Item 440711: Implemented proposals from git hub
+- Bug 442757: Admin Portal: The labeling of the Y-axis of the session charts is not recognizable
+- Bug 443316: ServiceCategoryComponent snackbar message are not translated
+
 ### December 12, 2023
 - Added some [code samples](sdk_samples/README.md) with explanations.
 

imxweb/custom-theme/readme.md

@@ -20,22 +20,21 @@ The HTML5 applications support the integration of **custom themes**. Before proc
   - `Class`: the CSS class identifier which is used for theming (e.g. `eui-light-theme` in default)
   - `Urls`: a list of all relevant files for this theme (also pictures, icons or other resources which are referenced if required)
 
-``` json
+```json
 {
-    "Themes": [
-        {
-            "Name": "space-theme",
-            "Display Name": "Space Theme",
-            "Class": "space-theme",
-            "Urls": [
-                "../space-theme/custom-theme.css"
-            ]
-        }
-    ]
+  "Themes": [
+    {
+      "Name": "space-theme",
+      "DisplayName": "Space Theme",
+      "Class": "space-theme",
+      "Urls": ["../space-theme/custom-theme.css"]
+    }
+  ]
 }
 ```
+
 - Upload the .zip file and the `imx-theme-config.json` file with Software Loader like you would with an Angular plugin.
 - Restart your API server.
 - Login to Web Portal > Click on your username > Select "User Interface Settings" > Change the application's theme to your custom theme.
 
-*Note*: Multiple theme definition files are possible. Multiple themes can also be declared inside one theme `imx-theme-config.json` file, however every theme needs to be provided as single .zip file.
+_Note_: Multiple theme definition files are possible. Multiple themes can also be declared inside one theme `imx-theme-config.json` file, however every theme needs to be provided as single .zip file.

imxweb/projects/aob/src/lib/applications/edit-application/service-category/service-category.component.ts

@@ -75,7 +75,7 @@ export class ServiceCategoryComponent {
       this.treeDatabase.updateNodeItem(entity);
       if (oldParent !== entity.GetColumn('UID_AccProductGroupParent').GetValue()) {
         this.tryToMoveElement(entity, entity.GetColumn('UID_AccProductGroupParent').GetValue());
-        this.snackbar.open({ key: 'Service category {0} was moved to a new parent', parameters: [entity.GetDisplay()] });
+        this.snackbar.open({ key: '#LDS#Service category {0} was moved to a new parent', parameters: [entity.GetDisplay()] });
       }
     } else {
       await entity.DiscardChanges();
@@ -97,7 +97,7 @@ export class ServiceCategoryComponent {
     }
 
     this.dataTreeWrapper.deleteNode(entity, false);
-    this.snackbar.open({ key: 'Service category {0} was deleted', parameters: [entity.GetDisplay()] });
+    this.snackbar.open({ key: '#LDS#Service category {0} was deleted', parameters: [entity.GetDisplay()] });
   }
 
   public async addChildCategory(evt: Event, entity: IEntity): Promise<void> {
@@ -115,7 +115,7 @@ export class ServiceCategoryComponent {
       } finally {
         this.busyService.hide(overlay);
       }
-      this.snackbar.open({ key: 'Service category {0} was created', parameters: [newEntity.GetDisplay()] });
+      this.snackbar.open({ key: '#LDS#Service category {0} was created', parameters: [newEntity.GetDisplay()] });
       this.add(entity, newEntity);
     } else {
       await entity.DiscardChanges();

imxweb/projects/aob/src/lib/entitlements/entitlement-add/entitlements-add.component.html

@@ -52,7 +52,7 @@
     </ng-container>
   </mat-card>
 </div>
-<div eui-sidesheet-actions color="white">
+<div eui-sidesheet-actions >
   <p class="imx-selected-entitlements">
     <eui-badge class="imx-badge" color="orange" data-imx-identifier="imx-entitlements-add-selected-items-badge">
       {{selections?.length || 0}}</eui-badge>

imxweb/projects/aob/src/lib/entitlements/entitlement-add/system-role-config/system-role-config.component.html

@@ -43,7 +43,7 @@
   </mat-card>
 </div>
 
-<div eui-sidesheet-actions color="white">
+<div eui-sidesheet-actions >
   <button *ngIf="type === 'new'" mat-raised-button color="primary" [disabled]="form.invalid || !form.dirty"
     (click)="close(true)" data-imx-identifier="system-role-config-create-new-system-role-button">
     {{'#LDS#Create new system role' | translate}}
@@ -52,4 +52,4 @@
     (click)="close(false)" data-imx-identifier="system-role-config-add-to-existing-system-role-button">
     {{'#LDS#Add to system role' | translate}}
   </button>
-</div>
+</div>

imxweb/projects/aob/src/lib/entitlements/entitlement-edit-auto-add/entitlement-edit-auto-add.component.html

@@ -4,10 +4,10 @@
   </imx-sqlwizard>
 </mat-card>
 </div>
-<div eui-sidesheet-actions color="white">
+<div eui-sidesheet-actions >
   <button class="justify-start" mat-stroked-button data-imx-identifier="entitlement-edit-auto-add-button-test-condition" (click)="showResults(false)">
     {{'#LDS#Test automatic assignment' |translate}}
   </button>
   <button [disabled]="controlsInvalid" mat-raised-button color="primary" (click)="showResults(true)" data-imx-identifier="entitlement-edit-auto-add-button-save-condition">
     {{'#LDS#Save automatic assignment' |translate}}</button>
-</div>
+</div>

imxweb/projects/aob/src/lib/entitlements/entitlement-edit-auto-add/entitlement-edit-auto-add.component.ts

@@ -87,7 +87,7 @@ export class EntitlementEditAutoAddComponent implements OnDestroy {
     });
     let elements: EntitlementToAddData;
     try {
-      this.setExtendedData(this.sqlExpression.Expression);
+      await this.setExtendedData(this.sqlExpression.Expression);
       elements = await this.svc.showEntitlementsToMap(this.data.application.InteractiveEntityStateData);
     } finally {
       setTimeout(() => {

imxweb/projects/aob/src/lib/entitlements/entitlement-edit-auto-add/mapped-entitlements-preview/mapped-entitlements-preview.component.html

@@ -25,7 +25,7 @@
     </imx-data-source-toolbar>
 
     <div class="imx-table-container">
-      <imx-data-table [dst]="dst" mode="manual" [detailViewVisible]="false" 
+      <imx-data-table [dst]="dst" mode="manual" [detailViewVisible]="false"
       [noDataText]="'#LDS#There are no matching application entitlements.' | translate"
         data-imx-identifier="mapped-entitlements-preview-datatable">
         <imx-data-table-column [entityColumn]="entitySchema?.Columns.DisplayName"
@@ -52,7 +52,7 @@
     </div>
   </mat-card>
 </div>
-<div eui-sidesheet-actions color="white" *ngIf="data.withSave">
+<div eui-sidesheet-actions  *ngIf="data.withSave">
   <mat-slide-toggle class="justify-start" #mappedslider checked="true"
     data-imx-identifier="mapped-entitlements-preview-slider-with-mapping">
     {{'#LDS#Assign application entitlements after saving' |translate}}
@@ -61,4 +61,4 @@
     (click)="apply(mappedslider.checked)">
     {{'#LDS#Save automatic assignment' |translate}}
   </button>
-</div>
+</div>

imxweb/projects/aob/src/lib/entitlements/entitlements.component.ts

@@ -112,8 +112,8 @@ export class EntitlementsComponent implements OnChanges {
    */
   public readonly status = {
     getBadges: (entitlement: PortalEntitlement): DataTileBadge[] => this.entitlementsProvider.getEntitlementBadges(entitlement),
-    enabled: (entitlement: PortalEntitlement): boolean => {
-      return !entitlement.IsDynamic.value;
+    enabled: (_: PortalEntitlement): boolean => {
+      return true;
     },
   };
 
@@ -477,7 +477,7 @@ export class EntitlementsComponent implements OnChanges {
       return;
     }
 
-    this.unassignedDisabled = false;
+    this.unassignedDisabled = selection.some(elem => elem.IsDynamic.value === true);
 
     let foundPublished = false;
     let foundUnpublished = false;

imxweb/projects/att/src/lib/attestation-action/attestation-action.service.ts

@@ -33,7 +33,7 @@ import { Subject } from 'rxjs';
 import { PortalAttestationApprove } from 'imx-api-att';
 import { CompareOperator, EntityData, FilterType, ValType } from 'imx-qbm-dbts';
 import { SnackBarService, EntityService, ColumnDependentReference, BaseCdr, ExtService, BaseReadonlyCdr, CdrFactoryService } from 'qbm';
-import { JustificationService, JustificationType, PersonService } from 'qer';
+import { JustificationService, JustificationType, PersonService, UserModelService } from 'qer';
 import { AttestationCasesService } from '../decision/attestation-cases.service';
 import { AttestationActionComponent } from './attestation-action.component';
 import { AttestationCase } from '../decision/attestation-case';
@@ -58,7 +58,8 @@ export class AttestationActionService {
     private readonly snackBar: SnackBarService,
     private readonly entityService: EntityService,
     private readonly person: PersonService,
-    private readonly workflow: AttestationWorkflowService,
+    private readonly workflow: AttestationWorkflowService,    
+    private readonly userService: UserModelService,
     private readonly extService: ExtService
   ) {}
 
@@ -506,6 +507,7 @@ export class AttestationActionService {
           await config.apply(attestationCase);
         }
         success = true;
+        await this.userService.reloadPendingItems();
       } finally {
         setTimeout(() => this.busyService.hide(busyIndicator));
       }

imxweb/projects/att/src/lib/decision/attestation-cases.service.ts

@@ -133,7 +133,7 @@ export class AttestationCasesService {
   }
 
   public getGroupInfo(parameters: { by?: string; def?: string } & CollectionLoadParameters = {}): Promise<GroupInfoData> {
-    const { OrderBy,search, ...params } = parameters;
+    const { withProperties, OrderBy, search, ...params } = parameters;
     return this.attClient.client.portal_attestation_approve_group_get({ ...params, withcount: true, Escalation: this.isChiefApproval });
   }
 

imxweb/projects/att/src/lib/new-user/new-user.component.html

@@ -27,7 +27,7 @@
   </mat-card>
 </div>
 
-<div eui-sidesheet-actions color="white">
+<div eui-sidesheet-actions >
   <button mat-raised-button (click)="captchaSvc.ReinitCaptcha()">
     {{ '#LDS#Refresh image' | translate}}
   </button>
@@ -36,4 +36,4 @@
     (click)="save()">
     {{'#LDS#Create account' | translate}}
   </button>
-</div>
+</div>

imxweb/projects/att/src/lib/pick-category/pick-category-select-identities/pick-category-select-identities.component.html

@@ -8,7 +8,7 @@
     <ng-container *ngTemplateOutlet="table">
     </ng-container>
   </div>
-  <div eui-sidesheet-actions color="white" *ngIf="!embeddedMode">
+  <div eui-sidesheet-actions  *ngIf="!embeddedMode">
     <p class="imx-selected-items">
       <span>
         {{'#LDS#Selected identities' | translate}}

imxweb/projects/att/src/lib/pick-category/pick-category-sidesheet/pick-category-sidesheet.component.html

@@ -32,7 +32,7 @@
     </div>
   </mat-card>
 </div>
-<div eui-sidesheet-actions color="white">
+<div eui-sidesheet-actions >
   <button mat-flat-button color="primary" data-imx-identifier="pick-category-sidesheet-details-button-save"
        (click)="saveChanges()" [disabled]="form.invalid || form.pristine">
        {{ '#LDS#Save' | translate}}

imxweb/projects/att/src/lib/policies/attestation-cases/attestation-cases.component.html

@@ -50,7 +50,7 @@
     <imx-data-source-paginator [dst]="dst"></imx-data-source-paginator>
   </mat-card>
 </div>
-<div eui-sidesheet-actions color="white" *ngIf="data.canCreateRuns && !hasSampleData">
+<div eui-sidesheet-actions  *ngIf="data.canCreateRuns && !hasSampleData">
   <button
     class="justify-start"
     mat-stroked-button

imxweb/projects/att/src/lib/policies/policy.service.ts

@@ -178,7 +178,7 @@ export class PolicyService {
   }
 
   public async getGroupInfo(parameters: { by?: string; def?: string } & CollectionLoadParameters = {}): Promise<GroupInfoData> {
-    const { OrderBy,search, ...params } = parameters;
+    const { withProperties, OrderBy, search, ...params } = parameters;
 
     const test = await this.api.client.portal_attestation_policy_group_get({
      ...params,

imxweb/projects/att/src/lib/runs/pending-approvers.component.scss

@@ -41,7 +41,6 @@
 }
 
 .imx-pending-approvers-container{
-  overflow: hidden;
   display: flex;
   flex-direction: column;
   height:100%;

imxweb/projects/att/src/lib/runs/runs.service.ts

@@ -80,7 +80,7 @@ export class RunsService {
   }
 
   public async getGroupInfo(parameters: RunsLoadParameters): Promise<GroupInfoData> {
-    const { groupFilter, search, OrderBy, ...params } = parameters;
+    const { withProperties, groupFilter, search, OrderBy, ...params } = parameters;
     return this.attService.client.portal_attestation_run_group_get({
       ...params,
       filter: parameters.groupFilter,