style(kanata): use key symbols #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnuttens
force-pushed
the
key-symbols
branch
from
28dde00 to
77498be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fancy symbols to help you memorize Arsenik’s layers 😎
I’m actually not so sure this is a good idea; sure, having clear symbols show up in Kanata’s logs can help newcomers, but I’d argue this is helpful for a limited time thanks to muscular memory.
Furthermore, these symbols are not so easy to handle with a text editor so I’m afraid it would do more harm to DX than good to beginners in the end.
Tell me what you think! 🙂