Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve user experience when open terminal in app container #80

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: improve user experience when open terminal in app container #80

merged 1 commit into from
Apr 26, 2024

Conversation

Altonhe
Copy link
Member

@Altonhe Altonhe commented Apr 26, 2024 •
edited
Loading

As #79 addressed, the PR fixed two problems:

  • Delete the /oba/webapps directory upon container configuration.
  • Set the user's default directory to be either /oba or /usr/local/tomcat. I'm not sure which and could be persuaded either way.

I set the default directory to /usr/local/tomcat to align with our base image. (see line 19)
https://hub.docker.com/layers/library/tomcat/8.5.98-jdk11-temurin/images/sha256-e44d60c70d98596f33a3039ae52a944162d37222b3efac679c5e0580cc78e2f3?context=explore

@Altonhe Altonhe marked this pull request as ready for review April 26, 2024 21:35
aaronbrethorst
aaronbrethorst approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 👍

@aaronbrethorst aaronbrethorst merged commit a048a00 into OneBusAway:main Apr 26, 2024
3 checks passed
@Altonhe Altonhe deleted the feature/docker branch July 12, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Altonhe @aaronbrethorst