feat: update transaction fees #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OU-1664 Include L2 fee math in the transformations repo
Reference this code from when we did this on the FE |
pcowgill
reviewed
Feb 9, 2024
| @@ -4,23 +4,21 @@ export function transform(block: RawBlock): RawBlock { | |||
| block.transactions = block.transactions.map((tx) => { | |||
There was a problem hiding this comment.
@jordanmessina @ponyjackal This would be a great function to unit test to make sure it can't underflow, overflow, etc. with realistic values for various L2s
pcowgill
approved these changes
Feb 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.