Don't treat erc20s like nfts in parties and fix #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OU-1701 Don't treat ERC20s like NFTs in parties and fix netAssetTransfers for legacy fake NFTs
Do keep the ERC20 contract there Don't have Memecoin #0, WETH #4574, etc. Screenshot 2024-02-13 at 9.11.44 AM.png https://www.onceupon.gg/0xfb62665dd247906395ece8d563acd41a0072db658dbeeb875390fef23541e1aa CryptoKitties should show up in net asset transfers CryptoPunks looks like an ERC20 in net asset transfers https://www.onceupon.gg/0xaf616d01e608c82ab2348b71ee296f3733ba6b4eca7bee6d100906c7fe6e4429 |
pcowgill
changed the title
pcowgill
approved these changes
Feb 26, 2024
pcowgill
deleted the
benguyen0214/ou-1701-dont-treat-erc20s-like-nfts-in-parties-and-fix
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.