Merge pull request #18 from Once-Upon/feature/undefined-var

Fix undefined error
Once-Upon · Feb 27, 2024 · 4deeb24 · 4deeb24
2 parents 87277f7 + d46bc9f
commit 4deeb24
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/src/blocks/ethereum/18965012_decoded.json b/src/blocks/ethereum/18965012_decoded.json
diff --git a/src/transformers/_common/parties.spec.ts b/src/transformers/_common/parties.spec.ts
@@ -62,5 +62,10 @@ describe('transactionParties', () => {
         '0x54b50187becd0bbcfd52ec5d538433dab044d2a8',
       ]);
     }
+
+    const block2 = loadBlockFixture('ethereum', '18965012_decoded');
+    const result2 = transform(block2);
+
+    expect(result2).toBeDefined();
   });
 });
diff --git a/src/transformers/_common/parties.ts b/src/transformers/_common/parties.ts
@@ -20,7 +20,9 @@ export function transform(block: RawBlock): RawBlock {
     const inputAddresses: string[] = tx.decoded
       ? tx.decoded.decoded
           .map((param) =>
-            param.type === 'address' ? param.decoded.toLowerCase() : '',
+            param.type === 'address' && param.decoded
+              ? param.decoded.toLowerCase()
+              : '',
           )
           .filter((address) => address !== '')
       : [];
@@ -42,7 +44,9 @@ export function transform(block: RawBlock): RawBlock {
       // grab event inputs params from decoded trace
       const partiesFromTrace = trace.decoded?.decoded
         .map((param) =>
-          param.type === 'address' ? param.decoded.toLowerCase() : '',
+          param.type === 'address' && param.decoded
+            ? param.decoded.toLowerCase()
+            : '',
         )
         .filter((address) => address !== '');
 
@@ -57,7 +61,9 @@ export function transform(block: RawBlock): RawBlock {
       // grab event inputs params from decoded log
       const partiesFromLog = log.decoded?.decoded
         .map((param) =>
-          param.type === 'address' ? param.decoded.toLowerCase() : '',
+          param.type === 'address' && param.decoded
+            ? param.decoded.toLowerCase()
+            : '',
         )
         .filter((address) => address !== '');