Digital Objects #1543
Open
Digital Objects #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamely
reviewed
Aug 24, 2017
There was a problem hiding this comment.
@andrewrothman see my two comments below.
also, what do you think about making the object interface 'hidden' by default and only loading and displaying it after a user receives or holds an object token
| @@ -32,8 +33,6 @@ def send_form_response(response_dict): | |||
| else: | |||
| response_status='invalid pubkey' | |||
| pubkey=None | |||
|
|
|||
| print response_dict | |||
There was a problem hiding this comment.
@andrewrothman please do not remove this, it is actually used when checking user reports of tx issues to verify what the api was received
| @@ -396,7 +396,9 @@ | |||
| "OPTIONS":"Wallet Options", | |||
| "OPTIONSTOGGLE":"Toggle Options", | |||
| "PORTFOLIO":"Portfolio Composition by value", | |||
| "WALLETID":"Wallet ID" | |||
| "WALLETID":"Wallet ID", | |||
There was a problem hiding this comment.
@andrewrothman please make sure to update all the lang files in the local folder.
also make sure to update the fallback lang file https://github.com/OmniLayer/omniwallet/blob/master/www/js/lang/en-US.js
|
Hey @andrewrothman, what's the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds digital object support to Omniwallet.
Also includes testnet fixes.