OCG Audit Remediations #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: RBS V1.4 - asymmetric spreads
RBS v1.3 - operate with TRSRY holding sDAI
…r executed" This reverts commit bd88440.
Script improvements
# Conflicts: # .github/workflows/CI.yml # .gitignore # .prettierignore # .solhintignore # CODE_STD.md # README.md # foundry.toml # lib/clones-with-immutable-args~bophades-develop # lib/ds-test~bophades-develop # lib/forge-proposal-simulator~bophades-develop # lib/forge-std~bophades-develop # lib/openzeppelin-contracts~bophades-develop # lib/solidity-examples~bophades-develop # lib/solmate~bophades-develop # package.json # remappings.txt # shell/full_install.sh # src/interfaces/IStaking.sol # src/policies/Distributor/Distributor.sol # src/policies/Heart.sol # src/policies/interfaces/IDistributor.sol # src/policies/interfaces/IHeart.sol # src/proposals/OCG.md # src/proposals/README.md # src/proposals/addresses.json # src/test/mocks/MockLegacyAuthority.sol # src/test/mocks/MockOhm.sol # src/test/policies/BoostedLiquidity/BLVaultLidoFork.t.sol # src/test/policies/BoostedLiquidity/BLVaultLusdFork.t.sol # src/test/policies/BoostedLiquidity/BLVaultManagerLidoFork.t.sol # src/test/policies/BoostedLiquidity/BLVaultManagerLusdFork.t.sol # src/test/policies/Heart.t.sol # src/test/sim/RangeSim.sol
Merge bophades/develop into olympus-v3 repo
…ocg-upgrade-merge # Conflicts: # src/scripts/deploy/deploy.json
# Conflicts: # src/test/policies/EmissionManager.t.sol # src/test/policies/Heart.t.sol # src/test/policies/ReserveMigrator.t.sol # src/test/proposals/EmissionManagerProposal.t.sol # src/test/proposals/OIP_168.t.sol # src/test/sim/RangeSim.sol
Fix: remappings, proposal testing, fork tests
OCG Upgrade: Migrate changes from bophades repo
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediations for the issues found in the OCG yAudit. The intent is to deploy a new version of the GovernorBravoDelegate and update the implementation to fix the few edge cases that were found.
The issues that were fixed are M3, L2, L3, L4, and I5.
M1 is not fixed because the likelihood is very low and the impact is minimal (would just need to resubmit the proposal). Additionally, it would require a change to the storage layout which we wish to avoid.
M2 is not truly fixable without deploying a new gOHM token, which would be a large amount of work. The impact of the issue is constrained to the amount of OHM that is flashloanable (less than 1% of supply). We also have the option to mitigate this issue entirely by enabling the staking warm-up (but with UX costs for users) if needed in the future.
L1 is more of an inconvenience than a true issue in that overpaying for an execution that requires native ETH can result in the executor overpaying. This can be resolved by refunding them at a later time.