Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Unused Deps #3039

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Cleanup Unused Deps #3039

wants to merge 21 commits into from

Conversation

brightiron
Copy link
Contributor

No description provided.

@socket-security Socket Security
Copy link

socket-security bot commented Dec 19, 2023 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @testing-library/[email protected], @types/[email protected], @types/[email protected], @types/[email protected], @types/[email protected], @vitejs/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

@brightiron brightiron mentioned this pull request Dec 22, 2023
Closed
@brightiron brightiron changed the title Cleanup deps Cleanup unused Deps Dec 22, 2023
@brightiron brightiron marked this pull request as ready for review December 22, 2023 02:32
@brightiron brightiron changed the title Cleanup unused Deps Cleanup Unused Deps Dec 22, 2023
@brightiron brightiron mentioned this pull request Dec 22, 2023
Closed
This was referenced Dec 22, 2023
Closed
Closed
Closed
Closed
unbanksy
unbanksy requested changes Dec 28, 2023
View reviewed changes
vite.config.js
? process.env.VITE_COOLER_LOANS_API_ENDPOINT
: mode === "development"
? "https://olympus-cooler-loans-api-dev.web.app" // Avoids CORS errors during local development
: "https://olympus-cooler-loans-api-prod.web.app", // Used in production builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is hosting this? Why do we need a separate endpoint to serve Cooler Loans?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for cooler loan metrics subgraph not for cooler loans. jem set this up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xJem could you comment on this piece.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hosted on Google Cloud

Repo is here: https://github.com/OlympusDAO/cooler-loans-api

Calculating the timeseries data in the frontend made it very slow, so it's shoved into an API that updates the data every 5 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJem 0xJem 0xJem left review comments

@unbanksy unbanksy unbanksy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brightiron @unbanksy @0xJem