Skip to content

Commit

Permalink
Upgrade Node.js used by CI/CD
Browse files Browse the repository at this point in the history
The Heroku CLI uses an embedded instance of Node.js. The embedded version was recently updated from Node.js 12.21.0 to 14.19.0. This repo's CI/CD workflows now use the current version of Node.js for the sake of consistency. However, the version of the `@types/node` dev dependency in `package.json` is intentionally left unchanged to ensure type compatibility for users that still have an older version of the Heroku CLI.
  • Loading branch information
OldSneerJaw committed May 27, 2022
1 parent ecd9c2f commit 4084c60
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
workflow_dispatch: # Allows the workflow to be triggered manually

env:
JOB_NODE_VERSION: '12.21.0' # Chosen to match what is used internally by the Heroku CLI
JOB_NODE_VERSION: '14.19.0' # Chosen to match what is used internally by the Heroku CLI

jobs:
lint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish
on: workflow_dispatch

env:
JOB_NODE_VERSION: '12.21.0' # Chosen to match what is used internally by the Heroku CLI
JOB_NODE_VERSION: '14.19.0' # Chosen to match what is used internally by the Heroku CLI

jobs:
publish:
Expand Down

0 comments on commit 4084c60

Please sign in to comment.