Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy.ps1 #865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update deploy.ps1 #865

wants to merge 1 commit into from

Conversation

jeff-bb
Copy link

@jeff-bb jeff-bb commented Sep 8, 2022

A couple of minor best practices changes around null checking and using aliases to maintain readability of the code.

Azure CLI tools will now download the latest version if nothing is installed, as well as explicitly use msiexec from system and not rely on path for that.

Also, allowing AzureADPreview to satisfy the requirement for AzureAD being installed. I left it as a warning in the messaging to the user.

A couple of minor best practices changes around null checking and using aliases to maintain readability of the code.

Azure CLI tools will now download the latest version if nothing is installed, as well as explicitly use msiexec from system and not rely on path for that.

Also, allowing AzureADPreview to satisfy the requirement for AzureAD being installed. I left it as a warning in the messaging to the user.
@ghost
Copy link

ghost commented Sep 8, 2022

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant