-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement New toolkit version csharp samples #1422
Open
Harikrishnan-MSFT
wants to merge
22
commits into
main
Choose a base branch
from
v-hrajandira/CsharpTTKMigration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harikrishnan-MSFT
added
the
DO NOT MERGE
Do not merge the PR due to incomplete changes or feature hasn't released yet.
label
Oct 14, 2024
Alive-Fish
approved these changes
Nov 20, 2024
@@ -89,11 +103,11 @@ Modify the `appsettings.json` file with the following details: | |||
- Update configuration with the ```MicrosoftAppId```, ```MicrosoftAppPassword``` and ```MicrosoftAppTenantId``` values received while doing Microsoft Entra ID app registration in your Azure portal. | |||
- Press `F5` to run the project | |||
|
|||
1) Modify the `manifest.json` in the `/AppManifest` folder | |||
1) Modify the `manifest.json` in the `/appPackage` folder | |||
Replace the following details: | |||
- `<<Your Microsoft App Id>>` with your MicrosoftAppId received after doing Microsoft Entra ID app registration in your Azure portal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to also update the variable names
HuihuiWu-Microsoft
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The env variable name is not critical issue, you can update in next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample List -
app-checkin-location/csharp
app-installation-using-qr-code/csharp
bot-proactive-messaging/csharp
bot-release-management/csharp
graph-bulk-meetings/csharp