Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated property name 'teamsApp' to 'teamsAppDefinition'. #1386

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pankajmunde12
Copy link
Contributor

Hi @Harikrishnan-MSFT
In HomeController.cs file, there is a method called SendNotificationToManager. This method tries to get the list of installed teams-applications for the user. The property name 'teamsApp' has been now modified to 'teamsAppDefinition' by the Microsoft. Hence, I have updated the same in SendNotificationToManager.

@pankajmunde12
Copy link
Contributor Author

@pankajmunde12 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@pankajmunde12
Copy link
Contributor Author

Hi @Pawank-MSFT, @Mohammed-MSFT
Could you please check this and provide your suggestion on this fix? If it looks correct, I would like to update the property name at few more places.
Thanks and Regards,
Pankaj Munde

@Pawank-MSFT
Copy link
Collaborator

@pankajmunde12 We have checked tab-request-approval sample with these changes but sample not working as expected, We have fixed that with these changes and also checking other samples also. Once its done first we'll merge this PR and right after we will updated code.

@pankajmunde12
Copy link
Contributor Author

Ok. Thanks @Pawank-MSFT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants