Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve precompile counting test #2742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve precompile counting test #2742

wants to merge 1 commit into from

Conversation

PlasmaPower
Copy link
Collaborator

  • Adding a new precompile can cause a divergence, even if it doesn't have any methods. Therefore, this PR keeps track of the number of methods + the number of precompiles added in every ArbOS version.
  • Debug precompiles' methods aren't visible for production chains, so they should be ignored for this test. It should be fine to retroactively add new methods to them (though adding new debug precompiles altogether would still cause a divergence I think).

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 17, 2024
@PlasmaPower PlasmaPower added testing This involves only test changes and removed s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. labels Oct 17, 2024
joshuacolvin0
joshuacolvin0 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee requested changes Nov 7, 2024
View reviewed changes
precompiles/precompile_test.go
for _, method := range precompile.Precompile().methods {
version := arbmath.MaxInt(method.arbosVersion, precompile.Precompile().arbosVersion)
innerPrecompile := precompile.Precompile()
newMethodsPerArbosVersion[innerPrecompile.arbosVersion]++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment explaining it and/or rename newMethodsper.. to newEntriesPer..

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee requested changes

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
testing This involves only test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PlasmaPower @CLAassistant @joshuacolvin0 @tsahee